Differential D3315 Diff 11735 swh/web/common/service.py

Changeset View

Standalone View

swh/web/common/service.py

# Copyright (C) 2015-2020 The Software Heritage developers		# Copyright (C) 2015-2020 The Software Heritage developers
# See the AUTHORS file at the top-level directory of this distribution		# See the AUTHORS file at the top-level directory of this distribution
# License: GNU Affero General Public License version 3, or any later version		# License: GNU Affero General Public License version 3, or any later version
# See top-level LICENSE file for more information		# See top-level LICENSE file for more information

import itertools		import itertools
import os		import os
import re		import re

from collections import defaultdict		from collections import defaultdict
from typing import Any, Dict, List, Set, Iterator, Optional, Tuple		from typing import Any, Dict, List, Set, Iterator, Optional, Tuple

from swh.model import hashutil		from swh.model import hashutil
from swh.model.identifiers import CONTENT, DIRECTORY, RELEASE, REVISION, SNAPSHOT		from swh.model.identifiers import CONTENT, DIRECTORY, RELEASE, REVISION, SNAPSHOT
from swh.storage.algos import diff, revisions_walker		from swh.storage.algos import diff, revisions_walker
		from swh.storage.algos.snapshot import snapshot_get_latest
from swh.vault.exc import NotFoundExc as VaultNotFoundExc		from swh.vault.exc import NotFoundExc as VaultNotFoundExc
from swh.web import config		from swh.web import config
from swh.web.common import converters		from swh.web.common import converters
from swh.web.common import query		from swh.web.common import query
from swh.web.common.exc import BadInputExc, NotFoundExc		from swh.web.common.exc import BadInputExc, NotFoundExc
from swh.web.common.origin_visits import get_origin_visit		from swh.web.common.origin_visits import get_origin_visit
from swh.web.common.typing import OriginInfo, OriginVisitInfo		from swh.web.common.typing import OriginInfo, OriginVisitInfo

▲ Show 20 Lines • Show All 990 Lines • ▼ Show 20 Lines	Args:
allowed_statuses: list of visit statuses considered		allowed_statuses: list of visit statuses considered
to find the latest snapshot for the visit. For instance,		to find the latest snapshot for the visit. For instance,
``allowed_statuses=['full']`` will only consider visits that		``allowed_statuses=['full']`` will only consider visits that
have successfully run to completion.		have successfully run to completion.

Returns:		Returns:
A dict filled with the snapshot content.		A dict filled with the snapshot content.
"""		"""
snapshot = storage.snapshot_get_latest(origin, allowed_statuses)		snapshot = snapshot_get_latest(storage, origin, allowed_statuses=allowed_statuses)
return converters.from_snapshot(snapshot)		if snapshot is None:
		return None
		return converters.from_snapshot(snapshot.to_dict())

		anlambertUnsubmitted Not Done Inline Actions I would rather write return converters.from_snapshot(snapshot.to_dict()) if snapshot is not None else None or if snapshot is not None: return converters.from_snapshot(snapshot.to_dict()) anlambert: I would rather write ```lang=python return converters.from_snapshot(snapshot.to_dict()) if…
		ardumontAuthorUnsubmitted Done Inline Actions yeah, i'd prefer the first one, but it's too long about 1 char ;) I'll rename to snp so it's fine ;) the second i stopped using since when using mypy when there are types complain about the missing return statement ¯\_(ツ)_/¯ I missed adding types to that function, I'll fix that if you don't mind ;) ardumont: yeah, i'd prefer the first one, but it's too long about 1 char ;) I'll rename to snp so it's…

def lookup_snapshot_branch_name_from_tip_revision(		def lookup_snapshot_branch_name_from_tip_revision(
snapshot_id: str, revision_id: str		snapshot_id: str, revision_id: str
) -> Optional[str]:		) -> Optional[str]:
"""Check if a revision corresponds to the tip of a snapshot branch		"""Check if a revision corresponds to the tip of a snapshot branch

Args:		Args:
snapshot_id: hexadecimal representation of a snapshot id		snapshot_id: hexadecimal representation of a snapshot id
▲ Show 20 Lines • Show All 251 Lines • Show Last 20 Lines