Page MenuHomeSoftware Heritage
Differential D3117 Diff 11082 swh/journal/tests/test_serializers.py

Changeset View

Standalone View

View Options

swh/journal/tests/test_serializers.py

# Copyright (C) 2017 The Software Heritage developers # Copyright (C) 2017-2020 The Software Heritage developers
# See the AUTHORS file at the top-level directory of this distribution # See the AUTHORS file at the top-level directory of this distribution
# License: GNU General Public License version 3, or any later version # License: GNU General Public License version 3, or any later version
# See top-level LICENSE file for more information # See top-level LICENSE file for more information
from collections import OrderedDict
import itertools import itertools
from collections import OrderedDict
from typing import Iterable
from swh.journal import serializers from swh.journal import serializers
from .conftest import TEST_OBJECTS from .conftest import TEST_OBJECTS
def test_key_to_kafka_repeatable(): def test_key_to_kafka_repeatable():
"""Check the kafka key encoding is repeatable""" """Check the kafka key encoding is repeatable"""
base_dict = { base_dict = {
Show All 29 Lines for object_type, objects in TEST_OBJECTS.items():
if isinstance(key, dict): if isinstance(key, dict):
assert pprinted_key[0], pprinted_key[-1] == "{}" assert pprinted_key[0], pprinted_key[-1] == "{}"
for dict_key in key.keys(): for dict_key in key.keys():
assert f"{dict_key}:" in pprinted_key assert f"{dict_key}:" in pprinted_key
if isinstance(key, bytes): if isinstance(key, bytes):
assert pprinted_key == key.hex() assert pprinted_key == key.hex()
def test_kafka_to_key():
"""Standard back and forth serialization with keys
"""
# All KeyType(s)
keys: Iterable[serializers.KeyType] = [
{"a": "foo", "b": "bar", "c": "baz",},
{"a": b"foobarbaz",},
b"foo",
]
for object_type, objects in TEST_OBJECTS.items():
for obj in objects:
key = serializers.object_key(object_type, obj)
keys.append(key)
ardumontAuthorUnsubmitted
Done
Inline Actions

Note that i tried to mock my way into testing the compatibility behavior.

But i hit a recursion problem. Since the current tox uses a msgpack version > 6
which has that optional (strict_map_key=False).

def test_kafka_to_key_compatibility(mocker):
    """Backward compatible back and forth serialization with keys

    This can be removed when msgpack > 5.6 is released (alongside try:except stanza in
    production code)

    """
    keys = [
        b"foo",
        b"bar",
        b"baz",
    ]

    def altered_msgpack_loads(key, raw, **kwargs):
        """For test purposes"""
        if 'strict_map_key' in kwargs:
            raise TypeError('Unsupported method')
        import msgpack
        return msgpack.loads(key, raw)

    m = mocker.patch('swh.journal.serializers.msgpack.loads')
    m.side_effect = altered_msgpack_loads

    for key in keys:
        ktk = serializers.key_to_kafka(key)
        v = serializers.kafka_to_key(ktk)

        assert v == key

    import pdb; pdb.set_trace()

    assert m.called
ardumont: Note that i tried to mock my way into testing the compatibility behavior. But i hit a…
for key in keys:
ktk = serializers.key_to_kafka(key)
v = serializers.kafka_to_key(ktk)
assert v == key
About · Developer information · Legal