Differential D2987 Diff 10834 swh/storage/tests/test_in_memory.py

Changeset View

Standalone View

swh/storage/tests/test_in_memory.py

	# Copyright (C) 2018-2020 The Software Heritage developers			# Copyright (C) 2018-2020 The Software Heritage developers
	# See the AUTHORS file at the top-level directory of this distribution			# See the AUTHORS file at the top-level directory of this distribution
	# License: GNU General Public License version 3, or any later version			# License: GNU General Public License version 3, or any later version
	# See top-level LICENSE file for more information			# See top-level LICENSE file for more information

	import pytest			import pytest

				from swh.storage.in_memory import SortedList
	from swh.storage.tests.test_storage import TestStorage, TestStorageGeneratedData # noqa			from swh.storage.tests.test_storage import TestStorage, TestStorageGeneratedData # noqa


	# tests are executed using imported classes (TestStorage and			# tests are executed using imported classes (TestStorage and
	# TestStorageGeneratedData) using overloaded swh_storage fixture			# TestStorageGeneratedData) using overloaded swh_storage fixture
	# below			# below


	@pytest.fixture			@pytest.fixture
	def swh_storage_backend_config():			def swh_storage_backend_config():
	yield {			yield {
	"cls": "memory",			"cls": "memory",
	"journal_writer": {"cls": "memory",},			"journal_writer": {"cls": "memory",},
	}			}


				parametrize = pytest.mark.parametrize(
				"items",
				[
				[1, 2, 3, 4, 5, 6, 10, 100],
				[10, 100, 6, 5, 4, 3, 2, 1],
				[10, 4, 5, 6, 1, 2, 3, 100],
				],
				)


				@parametrize
				def test_sorted_list_iter(items):
				list1 = SortedList()
				for item in items:
				list1.add(item)
				assert list(list1) == sorted(items)

				list2 = SortedList(items)
				assert list(list2) == sorted(items)


				@parametrize
				def test_sorted_list_iter__key(items):
				list1 = SortedList(key=lambda item: -item)
				for item in items:
				list1.add(item)
				assert list(list1) == list(reversed(sorted(items)))

				list2 = SortedList(items, key=lambda item: -item)
				assert list(list2) == list(reversed(sorted(items)))


				@parametrize
				def test_sorted_list_iter_from(items):
				list_ = SortedList(items)
				for split in items:
				expected = sorted(item for item in items if item >= split)
				ardumontUnsubmitted Not Done Inline Actions Arf... It took me a while to understand that `, split` is the string printed in case the assertion fails... Could you please make that more apparent? (same for the next test) For example: assert list(list_.iter_from(split)) == expected, f"split: {split}" or something better if you have ;) ardumont: Arf... It took me a while to understand that `, split` is the string printed in case the…
				assert list(list_.iter_from(split)) == expected, f"split: {split}"


				@parametrize
				def test_sorted_list_iter_from__key(items):
				list_ = SortedList(items, key=lambda item: -item)
				for split in items:
				expected = reversed(sorted(item for item in items if item <= split))
				assert list(list_.iter_from(-split)) == list(expected), f"split: {split}"