Changeset View
Changeset View
Standalone View
Standalone View
swh/storage/retry.py
Show First 20 Lines • Show All 170 Lines • ▼ Show 20 Lines | class RetryingProxyStorage: | ||||
@swh_retry | @swh_retry | ||||
def flush(self, object_types: Optional[Iterable[str]] = None) -> Dict: | def flush(self, object_types: Optional[Iterable[str]] = None) -> Dict: | ||||
"""Specific case for buffer proxy storage failing to flush data | """Specific case for buffer proxy storage failing to flush data | ||||
""" | """ | ||||
if hasattr(self.storage, "flush"): | if hasattr(self.storage, "flush"): | ||||
return self.storage.flush(object_types) | return self.storage.flush(object_types) | ||||
return {} | return {} | ||||
def clear_buffers(self, object_types: Optional[Iterable[str]] = None) -> None: | |||||
return self.storage.clear_buffers(object_types) | |||||
ardumont: Wondering if that'd make sense to define it as:
```
def clear_buffers(
self… | |||||
Not Done Inline ActionsPut your comment in the wrong place? And yes, I think the filter.py's clear_buffers should do that, or the contents will grow out of bounds. olasd: Put your comment in the wrong place? And yes, I think the `filter.py`'s `clear_buffers` should… | |||||
Done Inline Actionsmmmph, yeah wrong proxy ;) ardumont: mmmph, yeah wrong proxy ;) |
Wondering if that'd make sense to define it as:
That's not quite the same meaning, isn't it?