Changeset View
Changeset View
Standalone View
Standalone View
swh/lister/launchpad/tests/conftest.py
- This file was added.
| from swh.lister.core.tests.conftest import * # noqa | |||||
ardumont: drop swh_listers, you don't need it any longer. | |||||
Done Inline ActionsYes that's right legau: Yes that's right | |||||
Not Done Inline ActionsAnd actually, you are making the mock being injected to swh_listers without using it later. That feels strange. ardumont: And actually, you are making the mock being injected to `swh_listers` without using it later. | |||||
Not Done Inline Actionsyou are monkey-patching here and no longer mocking. Why not the initial with patch stanza you used earlier, that felt more standard, well at least on how we define it here in the team ;) ardumont: you are monkey-patching here and no longer mocking.
Why not the initial `with patch` stanza… | |||||
Done Inline Actionslister.launchpad.git_repositories.getRepositories is already a mocked object, would it be ok just to redefine its side_effect like lister.launchpad.git_repositories.getRepositories.side_effect =[mock_lp_response(i) for i in range(3)] legau: lister.launchpad.git_repositories.getRepositories is already a mocked object, would it be ok… | |||||
Not Done Inline ActionsI don't know yet, i'd like to see the current build's status first ;) ardumont: I don't know yet, i'd like to see the current build's status first ;)
So i'm focusing on that… | |||||
drop swh_listers, you don't need it any longer.