Changeset View
Changeset View
Standalone View
Standalone View
dynamic_form.js
Show All 29 Lines | fieldset.innerHTML = ` | ||||
<input type="email" id="${personPrefix}_email" name="${personPrefix}_email" | <input type="email" id="${personPrefix}_email" name="${personPrefix}_email" | ||||
placeholder="jane.doe@example.org" /> | placeholder="jane.doe@example.org" /> | ||||
</p> | </p> | ||||
<p> | <p> | ||||
<label for="${personPrefix}_id">URI</label> | <label for="${personPrefix}_id">URI</label> | ||||
<input type="url" id="${personPrefix}_id" name="${personPrefix}_id" | <input type="url" id="${personPrefix}_id" name="${personPrefix}_id" | ||||
placeholder="http://orcid.org/0000-0002-1825-0097" /> | placeholder="http://orcid.org/0000-0002-1825-0097" /> | ||||
</p> | </p> | ||||
<p> | |||||
<label for="${personPrefix}_affiliation">Affiliation</label> | |||||
<input type="url" id="${personPrefix}_affiliation" name="${personPrefix}_affiliation" | |||||
placeholder="Department of Computer Science, University of Pisa" /> | |||||
vlorentz: nitpick: indentation of the `<p>` block | |||||
Done Inline ActionsStill not done; the label and input are inside the p, so it should be: <p> <label for="${personPrefix}_affiliation">Affiliation</label> <input type="url" id="${personPrefix}_affiliation" name="${personPrefix}_affiliation" placeholder="Department of Computer Science, University of Pisa" /> </p> vlorentz: Still not done; the `label` and `input` are inside the `p`, so it should be:
```
<p>… | |||||
</p> | |||||
`; | `; | ||||
return fieldset; | return fieldset; | ||||
} | } | ||||
function addPersonWithId(container, prefix, legend, id) { | function addPersonWithId(container, prefix, legend, id) { | ||||
var fieldset = createPersonFieldset(`${prefix}_${id}`, `${legend} #${id}`); | var fieldset = createPersonFieldset(`${prefix}_${id}`, `${legend} #${id}`); | ||||
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines |
nitpick: indentation of the <p> block