Page MenuHomeSoftware Heritage
Differential D1784 Diff 6053 cypress/integration/origin-diff.spec.js

Changeset View

Standalone View

View Options

cypress/integration/origin-diff.spec.js

  • This file was added.
/**
* Copyright (C) 2019 The Software Heritage developers
* See the AUTHORS file at the top-level directory of this distribution
* License: GNU Affero General Public License version 3, or any later version
* See top-level LICENSE file for more information
*/
const origin = {
url: 'https://github.com/memononen/libtess2',
revision: '344b31572659aa74426c5c6ad91bbde3fe23bbb8'
};
let diffData;
describe('Test Diffs View', function() {
before(function() {
const url = this.Urls.browse_revision(origin.revision) + `?origin=${origin.url}`;
cy.visit(url).window().then(win => {
cy.request(win.diffRevUrl)
.then(res => {
diffData = res.body;
});
});
});
beforeEach(function() {
const url = this.Urls.browse_revision(origin.revision) + `?origin=${origin.url}`;
cy.visit(url);
cy.contains('a[data-toggle="tab"]', 'Changes')
anlambertUnsubmitted
Not Done
Inline Actions

You can chain the calls to the cypress API here

anlambert: You can chain the calls to the cypress API here
.click();
});
it('should list all files with changes', function() {
for (let change of diffData.changes) {
const fromFile = change.from_path;
const toFile = change.to_path;
anlambertUnsubmitted
Not Done
Inline Actions

Here I would put all paths in a Set first to avoid running some tests twice (from_path and to_path are equal when a file is modified)

anlambert: Here I would put all paths in a `Set` first to avoid running some tests twice (`from_path` and…
cy.get('#swh-revision-changes-list a')
.contains(fromFile)
.should('be.visible');
cy.get('#swh-revision-changes-list a')
.contains(toFile)
.should('be.visible');
}
});
it('should load diffs when scrolled down', function() {
kalpitkAuthorUnsubmitted
Done
Inline Actions

This test crashes the server with segmentation fault sometimes.
Can't figure out how a e2e test can lead to that.

kalpitk: This test crashes the server with segmentation fault sometimes. Can't figure out how a e2e test…
kalpitkAuthorUnsubmitted
Done
Inline Actions

(happens most of the times , when this spec file is run alone)

kalpitk: (happens most of the times , when this spec file is run alone)
anlambertUnsubmitted
Not Done
Inline Actions

I managed to reproduce the issue from my side but it took me some time to analyze it and fix it properly.

The segfault was due to the use of the file-magic package in swh-web.
We use it to detect the mime_type and the encoding of contents stored into the archive.
I already experienced issues with it by the past and had to add an ugly hack to workaround them (see a2759fec6009).
At the time, I did not understand that calls to the file-magic API are not thread-safe and the issue you encountered
helped me to find the real cause of the issue.

I have just committed 0721db0ce7e8 and cd747b23ec7f properly fixing the issue. While maintaining backward compatibility
for the file-magic use (this is what we use in production on debian stretch environment) and making it thread-safe, I decided to favorize the use of the python-magic package which is thread-safe and more popular among Python developers (plus it is the one packaged on debian buster).

anlambert: I managed to reproduce the issue from my side but it took me some time to analyze it and fix it…
cy.wait(500)
.then(() => {
const next = Cypress.$('#swh-nb-diffs-computed').text();
cy.get('div[id^="panel_"]:contains("Loading diff").card')
.eq(next)
.scrollIntoView()
.wait(300)
.find('.swh-content')
.should('be.visible');
});
});
});
anlambertUnsubmitted
Not Done
Inline Actions

Here I would rather use the implementation below as it is easier to understand:

it('should load diffs when scrolled down', function() {
    cy.wait(500)
      .get('#swh-revision-changes-list a')
      .each(elt => {
        cy.get(elt.attr('href'))
          .scrollIntoView()
          .wait(500)
          .find('.swh-content')
          .should('be.visible');
      });
  });
anlambert: Here I would rather use the implementation below as it is easier to understand: ```lang=js it…
About · Developer information · Legal