Differential D1610 Diff 5507 swh/lister/cgit/tests/test_tasks.py

Changeset View

Standalone View

				from unittest.mock import patch


				def test_ping(swh_app, celery_session_worker):
				res = swh_app.send_task(
				'swh.lister.cgit.tasks.ping')
				assert res
				res.wait()
				assert res.successful()
				assert res.result == 'OK'


				@patch('swh.lister.cgit.tasks.CGitLister')
				def test_lister(lister, swh_app, celery_session_worker):
				# setup the mocked CGitLister
				lister.return_value = lister
				lister.run.return_value = None

				res = swh_app.send_task(
				'swh.lister.cgit.tasks.CGitListerTask')
				assert res
				res.wait()
				assert res.successful()

				lister.assert_called_once_with(
				base_url='https://git.savannah.gnu.org/cgit/',
				instance='savannah-gnu')
				ardumontUnsubmitted Done Inline Actions Same as before. If url_prefix is not really used (as it's the same as url), drop it here. It's best to test the other cases though. So add other tests (dubbed `test_lister_no_url_prefix`, `test_lister_url_and_url_prefix` or something...) with different instance initializations. Possible scenarios i see are: one with only url one with url and url_prefix (different) add other combinations i don't know about (if any ;) ardumont: Same as before. If url_prefix is not really used (as it's the same as url), drop it here. It's…
				lister.db_last_index.assert_not_called()
				lister.run.assert_called_once_with()