Differential D1365 Diff 4690 swh/lister/phabricator/tests/test_pb_lister.py

Changeset View

Standalone View

				# Copyright (C) 2019-2020 the Software Heritage developers
				# License: GNU General Public License version 3, or any later version
				# See top-level LICENSE file for more information

				import re
				import unittest
				from swh.lister.core.tests.test_lister import HttpListerTester
				from swh.lister.phabricator.lister import PhabricatorLister


				class PhabricatorListerTester(HttpListerTester, unittest.TestCase):
				Lister = PhabricatorLister
				test_re = re.compile(r'\&after=([^?&]+)')
				lister_subdir = 'phabricator'
				good_api_response_file = 'api_response.json'
				bad_api_response_file = 'api_empty_response.json'
				first_index = 1
				last_index = 122
				entries_per_page = 100
				anlambertUnsubmitted Done Inline Actions Here you should add a new test method to check that the `get_repo_url` implementation is correct. Something like: swh.lister.phabricator.lister import get_repo_url def test_get_repo_url(self): # 1. parse the `good_api_reponse_file` with the `json` module # 2. iterate over each listed repository # 3. in each iteration step, call the get_repo_url function with the repository `attachments` # 4. check that the extracted url is the expected one (should be "<forge_url>/source/<shortName>.git" with our test cases) anlambert: Here you should add a new test method to check that the `get_repo_url` implementation is…