Changeset View
Changeset View
Standalone View
Standalone View
swh/web/tests/browse/views/test_release.py
| Show All 12 Lines | |||||
| from swh.web.tests.strategies import ( | from swh.web.tests.strategies import ( | ||||
| release, origin_with_release, unknown_release | release, origin_with_release, unknown_release | ||||
| ) | ) | ||||
| from swh.web.tests.testcase import WebTestCase | from swh.web.tests.testcase import WebTestCase | ||||
| class SwhBrowseReleaseTest(WebTestCase): | class SwhBrowseReleaseTest(WebTestCase): | ||||
| @given(release()) | def _release_browse_test(self, release, release_data): | ||||
| def test_release_browse(self, release): | |||||
| url = reverse('browse-release', | url = reverse('browse-release', | ||||
| url_args={'sha1_git': release}) | url_args={'sha1_git': release}) | ||||
| release_data = self.release_get(release) | |||||
| resp = self.client.get(url) | resp = self.client.get(url) | ||||
| self._release_browse_checks(resp, release_data) | self._release_browse_checks(resp, release_data) | ||||
| @given(release()) | |||||
| def test_release_browse(self, release): | |||||
| release_data = self.release_get(release) | |||||
| self._release_browse_test(release, release_data) | |||||
| @given(release()) | |||||
| def test_release_browse_with_uppercase_sha1(self, release): | |||||
anlambert: Here, I would rather write:
```lang=python
release = release.upper()
release_data = self. | |||||
| release = release.upper() | |||||
| release_data = self.release_get(release) | |||||
| release_data['id'] = release | |||||
| self._release_browse_test(release, release_data) | |||||
| @given(origin_with_release()) | @given(origin_with_release()) | ||||
| def test_release_browse_with_origin(self, origin): | def test_release_browse_with_origin(self, origin): | ||||
| snapshot = self.snapshot_get_latest(origin['id']) | snapshot = self.snapshot_get_latest(origin['id']) | ||||
| release = random.choice([b for b in snapshot['branches'].values() | release = random.choice([b for b in snapshot['branches'].values() | ||||
| if b['target_type'] == 'release']) | if b['target_type'] == 'release']) | ||||
| url = reverse('browse-release', | url = reverse('browse-release', | ||||
| url_args={'sha1_git': release['target']}, | url_args={'sha1_git': release['target']}, | ||||
| query_params={'origin': origin['url']}) | query_params={'origin': origin['url']}) | ||||
| ▲ Show 20 Lines • Show All 60 Lines • Show Last 20 Lines | |||||
Here, I would rather write: