Changeset View
Changeset View
Standalone View
Standalone View
swh/web/tests/api/views/test_revision.py
Show All 17 Lines | from swh.web.tests.strategies import ( | ||||
revision, unknown_revision, new_revision, | revision, unknown_revision, new_revision, | ||||
unknown_origin_id, origin, origin_with_multiple_visits | unknown_origin_id, origin, origin_with_multiple_visits | ||||
) | ) | ||||
from swh.web.tests.testcase import WebTestCase | from swh.web.tests.testcase import WebTestCase | ||||
class RevisionApiTestCase(WebTestCase, APITestCase): | class RevisionApiTestCase(WebTestCase, APITestCase): | ||||
@given(revision()) | def _api_revision_test(self, revision): | ||||
def test_api_revision(self, revision): | |||||
url = reverse('api-revision', url_args={'sha1_git': revision}) | url = reverse('api-revision', url_args={'sha1_git': revision}) | ||||
anlambert: There is no need to pass the `sha1_git` parameter here, you can directly use the `revision` one. | |||||
rv = self.client.get(url) | rv = self.client.get(url) | ||||
expected_revision = self.revision_get(revision) | expected_revision = self.revision_get(revision) | ||||
self._enrich_revision(expected_revision) | self._enrich_revision(expected_revision) | ||||
self.assertEqual(rv.status_code, 200) | self.assertEqual(rv.status_code, 200) | ||||
self.assertEqual(rv['Content-Type'], 'application/json') | self.assertEqual(rv['Content-Type'], 'application/json') | ||||
self.assertEqual(rv.data, expected_revision) | self.assertEqual(rv.data, expected_revision) | ||||
@given(revision()) | |||||
def test_api_revision(self, revision): | |||||
self._api_revision_test(revision) | |||||
Not Done Inline Actionsadapt method above and replace this two lines by one anlambert: adapt method above and replace this two lines by one | |||||
@given(revision()) | |||||
def test_api_revision_with_uppercase_sha1(self, revision): | |||||
self._api_revision_test(revision.upper()) | |||||
Not Done Inline Actionssame here anlambert: same here | |||||
@given(unknown_revision()) | @given(unknown_revision()) | ||||
def test_api_revision_not_found(self, unknown_revision): | def test_api_revision_not_found(self, unknown_revision): | ||||
url = reverse('api-revision', url_args={'sha1_git': unknown_revision}) | url = reverse('api-revision', url_args={'sha1_git': unknown_revision}) | ||||
rv = self.client.get(url) | rv = self.client.get(url) | ||||
self.assertEqual(rv.status_code, 404) | self.assertEqual(rv.status_code, 404) | ||||
self.assertEqual(rv['Content-Type'], 'application/json') | self.assertEqual(rv['Content-Type'], 'application/json') | ||||
▲ Show 20 Lines • Show All 479 Lines • Show Last 20 Lines |
There is no need to pass the sha1_git parameter here, you can directly use the revision one.