Differential D8426 Diff 30425 swh/graphql/tests/functional/test_visit_status.py

Changeset View

Standalone View

swh/graphql/tests/functional/test_visit_status.py

This file was added.

				# Copyright (C) 2022 The Software Heritage developers
				# See the AUTHORS file at the top-level directory of this distribution
				# License: GNU General Public License version 3, or any later version
				# See top-level LICENSE file for more information

				from ..data import get_visit_status, get_visits
				from .utils import get_query_response


				def test_get_visit_status(client):
				visit = get_visits()[3]
				query_str = """
				{
				visit(originUrl: "%s", visitId: %s) {
				status(first: 3) {
				nodes {
				status
				date
				type
				snapshot {
				swhid
				}
				}
				}
				}
				}
				""" % (
				visit.origin,
				visit.visit,
				)
				data, _ = get_query_response(client, query_str)
				result_status = get_visit_status()[3]
				assert data["visit"]["status"]["nodes"][0] == {
				"date": result_status.date.isoformat(),
				"snapshot": {"swhid": f"swh:1:snp:{result_status.snapshot.hex()}"},
				"status": result_status.status,
				"type": result_status.type,
				}


				def test_get_visit_missing_snapshot(client):
				visit = get_visits()[0]
				query_str = """
				{
				visit(originUrl: "%s", visitId: %s) {
				status(first: 3) {
				nodes {
				status
				date
				type
				snapshot {
				swhid
				}
				}
				}
				}
				}
				""" % (
				visit.origin,
				visit.visit,
				)
				data, err = get_query_response(client, query_str)
				result_status = get_visit_status()[0]
				assert data["visit"]["status"]["nodes"][0] == {
				"date": result_status.date.isoformat(),
				"snapshot": None,
				"status": result_status.status,
				"type": result_status.type,
				}
				assert err is None
				anlambertUnsubmitted Done Inline Actions Both tests are quite similar, you should merge them into a single one using pytest parametrize decorator: @pytest.mark.parametrize( "visit, visit_status", list(zip(get_visits(), get_visit_status())) ) def test_get_visit_status(client, visit, visit_status): query_str = """ { visit(originUrl: "%s", visitId: %s) { status(first: 3) { nodes { status date type snapshot { swhid } } } } } """ % ( visit.origin, visit.visit, ) data, err = get_query_response(client, query_str) assert data["visit"]["status"]["nodes"][0] == { "date": visit_status.date.isoformat(), "snapshot": {"swhid": f"swh:1:snp:{visit_status.snapshot.hex()}"} if visit_status.snapshot is not None else None, "status": visit_status.status, "type": visit_status.type, } assert err is None anlambert: Both tests are quite similar, you should merge them into a single one using pytest parametrize…