Page MenuHomeSoftware Heritage
Differential D8287 Diff 29921 swh/lister/pubdev/tests/test_lister.py

Changeset View

Standalone View

View Options

swh/lister/pubdev/tests/test_lister.py

  • This file was added.
# Copyright (C) 2022 The Software Heritage developers
# See the AUTHORS file at the top-level directory of this distribution
# License: GNU General Public License version 3, or any later version
# See top-level LICENSE file for more information
from swh.lister.pubdev.lister import PubDevLister
expected_origins = [
{
"url": "https://pub.dev/api/packages/Autolinker",
"visit_type": "pubdev",
"extra_loader_arguments": {
"artifacts": [
{
"url": "https://pub.dartlang.org/packages/Autolinker/versions/0.1.0.tar.gz",
"version": "0.1.0",
},
{
"url": "https://pub.dartlang.org/packages/Autolinker/versions/0.1.1.tar.gz",
"version": "0.1.1",
},
],
"pubdev_metadata": [
{
"pubspec": {
"name": "Autolinker",
"author": "hackcave <hackers@hackcave.org>",
"version": "0.1.0",
"homepage": "https://github.com/hackcave",
"description": "Port of Autolinker.js to dart",
},
"version": "0.1.0",
"published": "2014-12-24T21:16:03.118270Z",
"archive_url": "https://pub.dartlang.org/packages/Autolinker/versions/0.1.0.tar.gz", # noqa: B950
},
{
"pubspec": {
"name": "Autolinker",
"author": "hackcave <hackers@hackcave.org>",
"version": "0.1.1",
"homepage": "https://github.com/hackcave",
"description": "Port of Autolinker.js to dart",
},
"version": "0.1.1",
"published": "2014-12-24T22:34:02.534090Z",
"archive_url": "https://pub.dartlang.org/packages/Autolinker/versions/0.1.1.tar.gz", # noqa: B950
},
],
},
vlorentzUnsubmitted
Done
Inline Actions
assert res.origins == 1 + 1
- scheduler_origins_sorted = sorted(
- swh_scheduler.get_listed_origins(lister.lister_obj.id).results,
- key=lambda x: x.url,
- )
- expected_origins_sorted = sorted(expected_origins, key=lambda x: x.get("url"))
- scheduler_origins_sorted = sorted(
- swh_scheduler.get_listed_origins(lister.lister_obj.id).results,
- key=lambda x: x.url,
- )
+ scheduler_origins = swh_scheduler.get_listed_origins(lister.lister_obj.id).results
assert len(scheduler_origins_sorted) == len(expected_origins_sorted)
- assert [
+ assert {
(
scheduled.visit_type,
scheduled.url,
)
- for scheduled in scheduler_origins_sorted
- ] == [
+ for scheduled in scheduler_origins
+ } == {
(
"pubdev",
- expected.get("url"),
+ expected["url"],
)
- for expected in expected_origins_sorted
- ]
+ for expected in expected_origins
+ }

You can use set equality to simplify this. On error, pytest can be smart and diff set content just as well as lists

Also I removed a redundant assignment and length comparison.

vlorentz: You can use set equality to simplify this. On error, pytest can be smart and diff set content…
},
{
"url": "https://pub.dev/api/packages/pdf",
"visit_type": "pubdev",
"extra_loader_arguments": {
"artifacts": [
{
"url": "https://pub.dartlang.org/packages/pdf/versions/1.0.0.tar.gz",
"version": "1.0.0",
},
{
"url": "https://pub.dartlang.org/packages/pdf/versions/3.8.2.tar.gz",
"version": "3.8.2",
},
],
"pubdev_metadata": [
{
"pubspec": {
"name": "pdf",
"author": "David PHAM-VAN <dev.nfet.net@gmail.com>",
"version": "1.0.0",
"homepage": "https://github.com/davbfr/dart_pdf",
"description": "A pdf producer for Dart",
"environment": {"sdk": ">=1.8.0 <2.0.0"},
"dependencies": {
"meta": "^1.1.5",
"ttf_parser": "^1.0.0",
"vector_math": "^2.0.7",
},
"dev_dependencies": {"test": "any"},
},
"version": "1.0.0",
"published": "2018-07-16T21:12:28.894137Z",
"archive_url": "https://pub.dartlang.org/packages/pdf/versions/1.0.0.tar.gz", # noqa: B950
},
{
"pubspec": {
"name": "pdf",
"version": "3.8.2",
"homepage": "https://github.com/DavBfr/dart_pdf/tree/master/pdf",
"repository": "https://github.com/DavBfr/dart_pdf",
"description": "A pdf producer for Dart. It can create pdf files for both web or flutter.", # noqa: B950
"environment": {"sdk": ">=2.12.0 <3.0.0"},
"dependencies": {
"xml": ">=5.1.0 <7.0.0",
"meta": ">=1.3.0 <2.0.0",
"image": ">=3.0.1 <4.0.0",
"crypto": "^3.0.0",
"archive": "^3.1.0",
"barcode": ">=2.2.0 <3.0.0",
"vector_math": "^2.1.0",
"path_parsing": ">=0.2.0 <2.0.0",
},
"issue_tracker": "https://github.com/DavBfr/dart_pdf/issues",
"dev_dependencies": {
"test": ">=1.16.0 <2.0.0",
"flutter_lints": "^1.0.4",
},
},
"version": "3.8.2",
"published": "2022-07-25T11:38:25.983876Z",
"archive_url": "https://pub.dartlang.org/packages/pdf/versions/3.8.2.tar.gz", # noqa: B950
},
],
},
},
]
def test_pubdev_lister(datadir, requests_mock_datadir, swh_scheduler):
lister = PubDevLister(scheduler=swh_scheduler)
res = lister.run()
assert res.pages == 1 + 1
assert res.origins == 1 + 1
scheduler_origins_sorted = sorted(
swh_scheduler.get_listed_origins(lister.lister_obj.id).results,
key=lambda x: x.url,
)
expected_origins_sorted = sorted(expected_origins, key=lambda x: x.get("url"))
scheduler_origins_sorted = sorted(
swh_scheduler.get_listed_origins(lister.lister_obj.id).results,
key=lambda x: x.url,
)
assert len(scheduler_origins_sorted) == len(expected_origins_sorted)
assert [
(
scheduled.visit_type,
scheduled.url,
scheduled.extra_loader_arguments.get("artifacts"),
scheduled.extra_loader_arguments.get("pubdev_metadata"),
)
for scheduled in scheduler_origins_sorted
] == [
(
"pubdev",
expected.get("url"),
expected.get("extra_loader_arguments").get("artifacts"),
expected.get("extra_loader_arguments").get("pubdev_metadata"),
)
for expected in expected_origins_sorted
]
About · Developer information · Legal