Changeset View
Changeset View
Standalone View
Standalone View
swh/web/tests/api/views/test_origin.py
| # Copyright (C) 2015-2018 The Software Heritage developers | # Copyright (C) 2015-2018 The Software Heritage developers | ||||
| # See the AUTHORS file at the top-level directory of this distribution | # See the AUTHORS file at the top-level directory of this distribution | ||||
| # License: GNU Affero General Public License version 3, or any later version | # License: GNU Affero General Public License version 3, or any later version | ||||
| # See top-level LICENSE file for more information | # See top-level LICENSE file for more information | ||||
| import random | |||||
| from rest_framework.test import APITestCase | from rest_framework.test import APITestCase | ||||
| from unittest.mock import patch | from unittest.mock import patch | ||||
| from swh.storage.exc import StorageDBError, StorageAPIError | from swh.storage.exc import StorageDBError, StorageAPIError | ||||
| from swh.web.common.utils import reverse | |||||
| from swh.web.tests.strategies import new_origin, set_hypothesis_settings | |||||
| from swh.web.tests.testcase import WebTestCase | from swh.web.tests.testcase import WebTestCase | ||||
| class OriginApiTestCase(WebTestCase, APITestCase): | class OriginApiTestCase(WebTestCase, APITestCase): | ||||
| def setUp(self): | def setUp(self): | ||||
| self.origin_visit1 = { | self.origin_visit1 = { | ||||
| 'date': 1104616800.0, | 'date': 1104616800.0, | ||||
| ▲ Show 20 Lines • Show All 337 Lines • ▼ Show 20 Lines | class OriginApiTestCase(WebTestCase, APITestCase): | ||||
| @patch('swh.web.common.service.idx_storage') | @patch('swh.web.common.service.idx_storage') | ||||
| def test_api_origin_metadata_search_invalid(self, mock_idx_storage): | def test_api_origin_metadata_search_invalid(self, mock_idx_storage): | ||||
| rv = self.client.get('/api/1/origin/metadata-search/') | rv = self.client.get('/api/1/origin/metadata-search/') | ||||
| # then | # then | ||||
| self.assertEqual(rv.status_code, 400, rv.content) | self.assertEqual(rv.status_code, 400, rv.content) | ||||
| mock_idx_storage.assert_not_called() | mock_idx_storage.assert_not_called() | ||||
| def test_api_origins_get(self): | |||||
| nb_origins = 200 | |||||
| new_origins = [] | |||||
| set_hypothesis_settings(max_examples=nb_origins) | |||||
| for _ in range(nb_origins): | |||||
| new_origins.append(new_origin().example()) | |||||
| set_hypothesis_settings(max_examples=1) | |||||
vlorentz: Is this how `example()` is supposed to be used with hypothesis? It looks like it exepects that… | |||||
anlambertAuthorUnsubmitted Done Inline ActionsThe issue here is that I restrain the maximum number of examples to 1 to speedup overall tests execution. However, I agree that this code could be put in a dedicated strategy function as anlambert: The issue here is that I restrain the maximum number of examples to 1 to speedup overall tests… | |||||
| expected_origins = self.storage.origin_add(new_origins) | |||||
| origin_from_idx = random.randint(1, nb_origins-1) | |||||
| origin_from = expected_origins[origin_from_idx]['id'] | |||||
| max_origin_idx = expected_origins[-1]['id'] | |||||
| origin_count = random.randint(1, max_origin_idx - origin_from) | |||||
| url = reverse('api-origins', | |||||
| query_params={'origin_from': origin_from, | |||||
| 'origin_count': origin_count}) | |||||
| rv = self.client.get(url) | |||||
| self.assertEqual(rv.status_code, 200) | |||||
| start = origin_from_idx | |||||
| end = origin_from_idx + origin_count | |||||
| expected_origins = expected_origins[start:end] | |||||
| for origin in expected_origins: | |||||
| origin['origin_visits_url'] = reverse( | |||||
| 'api-origin-visits', url_args={'origin_id': origin['id']}) | |||||
| self.assertEqual(rv.data, expected_origins) | |||||
| next_origin_id = expected_origins[-1]['id']+1 | |||||
| if self.storage.origin_get({'id': next_origin_id}): | |||||
| self.assertIn('Link', rv) | |||||
| next_url = reverse('api-origins', | |||||
| query_params={'origin_from': next_origin_id, | |||||
| 'origin_count': origin_count}) | |||||
| self.assertIn(next_url, rv['Link']) | |||||
| prev_origin_id = max(1, expected_origins[0]['id'] - origin_count) | |||||
| if expected_origins[0]['id'] != 1: | |||||
| self.assertIn('Link', rv) | |||||
| prev_url = reverse('api-origins', | |||||
| query_params={'origin_from': prev_origin_id, | |||||
| 'origin_count': origin_count}) | |||||
| self.assertIn(prev_url, rv['Link']) | |||||
Is this how example() is supposed to be used with hypothesis? It looks like it exepects that "one call of the test function = one example".
Shouldn't we ask hypothesis to build a list of origins instead?