Differential D897 Diff 2833 swh/storage/in_memory.py

Changeset View

Standalone View

swh/storage/in_memory.py

Show All 32 Lines	def __init__(self):
self._content_indexes = defaultdict(lambda: defaultdict(set))		self._content_indexes = defaultdict(lambda: defaultdict(set))

self._directories = {}		self._directories = {}
self._revisions = {}		self._revisions = {}
self._releases = {}		self._releases = {}
self._snapshots = {}		self._snapshots = {}
self._origins = []		self._origins = []
self._origin_visits = []		self._origin_visits = []
		self._persons = []
self._origin_metadata = defaultdict(list)		self._origin_metadata = defaultdict(list)
self._tools = {}		self._tools = {}
self._metadata_providers = {}		self._metadata_providers = {}
self._objects = defaultdict(list)		self._objects = defaultdict(list)

# ideally we would want a skip list for both fast inserts and searches		# ideally we would want a skip list for both fast inserts and searches
self._sorted_sha1s = []		self._sorted_sha1s = []

▲ Show 20 Lines • Show All 361 Lines • ▼ Show 20 Lines	def revision_add(self, revisions):
- parents (:class:`list[sha1_git]`): the parents of		- parents (:class:`list[sha1_git]`): the parents of
this revision		this revision

date dictionaries have the form defined in :mod:`swh.model`.		date dictionaries have the form defined in :mod:`swh.model`.
"""		"""
for revision in revisions:		for revision in revisions:
if revision['id'] not in self._revisions:		if revision['id'] not in self._revisions:
self._revisions[revision['id']] = rev = copy.deepcopy(revision)		self._revisions[revision['id']] = rev = copy.deepcopy(revision)
		self._person_add(rev['committer'])
		self._person_add(rev['author'])
rev['date'] = normalize_timestamp(rev.get('date'))		rev['date'] = normalize_timestamp(rev.get('date'))
rev['committer_date'] = normalize_timestamp(		rev['committer_date'] = normalize_timestamp(
rev.get('committer_date'))		rev.get('committer_date'))
self._objects[revision['id']].append(		self._objects[revision['id']].append(
('revision', revision['id']))		('revision', revision['id']))

def revision_missing(self, revision_ids):		def revision_missing(self, revision_ids):
"""List revisions missing from storage		"""List revisions missing from storage
▲ Show 20 Lines • Show All 68 Lines • ▼ Show 20 Lines	def release_add(self, releases):
- comment (:class:`bytes`): the comment associated with		- comment (:class:`bytes`): the comment associated with
the release		the release
- author (:class:`Dict[str, bytes]`): dictionary with		- author (:class:`Dict[str, bytes]`): dictionary with
keys: name, fullname, email		keys: name, fullname, email

the date dictionary has the form defined in :mod:`swh.model`.		the date dictionary has the form defined in :mod:`swh.model`.
"""		"""
for rel in releases:		for rel in releases:
		rel = copy.deepcopy(rel)
rel['date'] = normalize_timestamp(rel['date'])		rel['date'] = normalize_timestamp(rel['date'])
		self._person_add(rel['author'])
self._objects[rel['id']].append(		self._objects[rel['id']].append(
('release', rel['id']))		('release', rel['id']))
self._releases.update((rel['id'], rel) for rel in releases)		self._releases[rel['id']] = rel

def release_missing(self, releases):		def release_missing(self, releases):
"""List releases missing from storage		"""List releases missing from storage

Args:		Args:
releases: an iterable of release ids		releases: an iterable of release ids

Returns:		Returns:
▲ Show 20 Lines • Show All 497 Lines • ▼ Show 20 Lines	def origin_visit_get_by(self, origin, visit):

"""		"""
origin_visit = None		origin_visit = None
if origin <= len(self._origin_visits) and \		if origin <= len(self._origin_visits) and \
visit <= len(self._origin_visits[origin-1]):		visit <= len(self._origin_visits[origin-1]):
origin_visit = self._origin_visits[origin-1][visit-1]		origin_visit = self._origin_visits[origin-1][visit-1]
return origin_visit		return origin_visit

		def _person_add(self, person):
		"""Add a person in storage.

		Note: Internal function for now, do not use outside of this module.

		Do not do anything fancy in case a person already exists.
		Please adapt code if more checks are needed.

		Args:
		person: dictionary with keys name and email.

		Returns:
		olasdUnsubmitted Not Done Inline Actions could you swap the if and yield? it'd avoid needing the backslash olasd: could you swap the if and yield? it'd avoid needing the backslash
		Id of the new person.

		"""
		if person not in self._persons:
		person_id = len(self._persons) + 1
		self._persons.append(dict(person))
		key = (person['name'], person['email'])
		self._objects[key].append(('person', person_id))
		else:
		person_id = self._persons.index(person)
		person_id = person_id + 1
		person['id'] = person_id
		return person_id

		def person_get(self, person):
		"""Return the persons identified by their ids.

		Args:
		person: array of ids.

		Returns:
		The array of persons corresponding of the ids.

		"""
		for p in person:
		yield dict(self._persons[p - 1], id=p) \
		if 0 <= (p - 1) < len(self._persons) else None

def stat_counters(self):		def stat_counters(self):
"""compute statistics about the number of tuples in various tables		"""compute statistics about the number of tuples in various tables

Returns:		Returns:
dict: a dictionary mapping textual labels (e.g., content) to		dict: a dictionary mapping textual labels (e.g., content) to
integer values (e.g., the number of tuples in table content)		integer values (e.g., the number of tuples in table content)

"""		"""
▲ Show 20 Lines • Show All 182 Lines • ▼ Show 20 Lines
@staticmethod		@staticmethod
def _content_key(content):		def _content_key(content):
"""A stable key for a content"""		"""A stable key for a content"""
return tuple(content.get(key) for key in sorted(DEFAULT_ALGORITHMS))		return tuple(content.get(key) for key in sorted(DEFAULT_ALGORITHMS))

@staticmethod		@staticmethod
def _tool_key(tool):		def _tool_key(tool):
return (tool['name'], tool['version'],		return (tool['name'], tool['version'],
tuple(sorted(tool['configuration'].items())))		tuple(sorted(tool['configuration'].items())))
		olasdUnsubmitted Not Done Inline Actions I'm not sure what the semantics of `self._objects` is, but using it for this check doesn't feel right: what if someone's full name ends up being a valid object identifier for another type? olasd: I'm not sure what the semantics of `self._objects` is, but using it for this check doesn't feel…
		anlambertAuthorUnsubmitted Done Inline Actions Based on my understanding of vlorentz implementation, the `_objects` dict enable to easily lookup objects by sha1s and count object by type for the stat counters. Other keys in that dict corresponds to sha1s or (origin_type, origin_url) tuples so it's safe to use fullname as key here. I did not want to add another dict as class member as I knew I could use the `_objects` one. anlambert: Based on my understanding of vlorentz implementation, the `_objects` dict enable to easily…
		olasdUnsubmitted Not Done Inline Actions I mean, technically, a full name could match a sha1 (yeah, I know it's more than a bit far-fetched). I don't think it matters much, it's just a bit surprising. olasd: I mean, technically, a full name could match a sha1 (yeah, I know it's more than a bit far…
		anlambertAuthorUnsubmitted Done Inline Actions Ok, will use a tuple key instead and land that diff anlambert: Ok, will use a tuple key instead and land that diff

@staticmethod		@staticmethod
def _metadata_provider_key(provider):		def _metadata_provider_key(provider):
return (provider['name'], provider['url'])		return (provider['name'], provider['url'])