Differential D6695 Diff 24481 swh/web/tests/browse/views/test_directory.py

Changeset View

Standalone View

swh/web/tests/browse/views/test_directory.py

# Copyright (C) 2017-2021 The Software Heritage developers		# Copyright (C) 2017-2021 The Software Heritage developers
# See the AUTHORS file at the top-level directory of this distribution		# See the AUTHORS file at the top-level directory of this distribution
# License: GNU Affero General Public License version 3, or any later version		# License: GNU Affero General Public License version 3, or any later version
# See top-level LICENSE file for more information		# See top-level LICENSE file for more information

import random		import random
		import re

from hypothesis import given		from hypothesis import given
import pytest		import pytest

from django.utils.html import escape		from django.utils.html import escape

from swh.model.from_disk import DentryPerms		from swh.model.from_disk import DentryPerms
from swh.model.hashutil import hash_to_bytes, hash_to_hex		from swh.model.hashutil import hash_to_bytes, hash_to_hex
Show All 10 Lines	from swh.model.model import (
TimestampWithTimezone,		TimestampWithTimezone,
)		)
from swh.model.model import Directory, DirectoryEntry		from swh.model.model import Directory, DirectoryEntry
from swh.model.model import ObjectType as ModelObjectType		from swh.model.model import ObjectType as ModelObjectType
from swh.model.swhids import ObjectType		from swh.model.swhids import ObjectType
from swh.storage.utils import now		from swh.storage.utils import now
from swh.web.browse.snapshot_context import process_snapshot_branches		from swh.web.browse.snapshot_context import process_snapshot_branches
from swh.web.common.identifiers import gen_swhid		from swh.web.common.identifiers import gen_swhid
from swh.web.common.utils import gen_path_info, reverse		from swh.web.common.utils import (
		format_utc_iso_date,
		gen_path_info,
		parse_iso8601_date_to_utc,
		reverse,
		)
from swh.web.tests.django_asserts import assert_contains, assert_not_contains		from swh.web.tests.django_asserts import assert_contains, assert_not_contains
from swh.web.tests.strategies import new_person, new_swh_date		from swh.web.tests.strategies import (
		new_origin,
		new_person,
		new_snapshot,
		new_swh_date,
		visit_dates,
		)
from swh.web.tests.utils import check_html_get_response		from swh.web.tests.utils import check_html_get_response


def test_root_directory_view(client, archive_data, directory):		def test_root_directory_view(client, archive_data, directory):
_directory_view_checks(client, directory, archive_data.directory_ls(directory))		_directory_view_checks(client, directory, archive_data.directory_ls(directory))


def test_sub_directory_view(client, archive_data, directory_with_subdirs):		def test_sub_directory_view(client, archive_data, directory_with_subdirs):
▲ Show 20 Lines • Show All 498 Lines • ▼ Show 20 Lines	browse_url = reverse(
"release": release_name,		"release": release_name,
"snapshot": snapshot.id.hex(),		"snapshot": snapshot.id.hex(),
},		},
)		)

check_html_get_response(		check_html_get_response(
client, browse_url, status_code=200, template_used="browse/directory.html"		client, browse_url, status_code=200, template_used="browse/directory.html"
)		)


		# starts

		# def test_pull_request_branches_filtering(
		# client, origin_with_pull_request_branches, archive_data
		# ):
		# origin_url = origin_with_pull_request_branches.url
		# # check no pull request branches are displayed in the Branches / Releases dropdown
		# url = reverse("browse-origin-directory", query_params={"origin_url": origin_url})
		# resp = check_html_get_response(
		# client, url, status_code=200, template_used="browse/directory.html"
		# )
		# assert_not_contains(resp, "refs/pull/")

		# snapshot = archive_data.snapshot_get_latest(origin_url)
		# # check no pull request branches are displayed in the branches view
		# url = reverse(
		# "browse-snapshot-branches",
		# url_args={"snapshot_id": snapshot["id"]},
		# query_params={"origin_url": origin_url},
		# )
		# resp = check_html_get_response(
		# client, url, status_code=200, template_used="browse/branches.html"
		# )
		# assert_not_contains(resp, "refs/pull/")

		# @pytest.mark.django_db
		# @pytest.mark.parametrize("object_type", ["directory"])
		# @given(new_origin())
		# def test_browse_origin_content_directory_empty_snapshot(
		# client, staff_user, archive_data, object_type, new_origin
		# ):

		# _add_empty_snapshot_origin(new_origin, archive_data)

		# # to check proper generation of raw extrinsic metadata api links
		# client.force_login(staff_user)

		# url = reverse(
		# f"browse-origin-{object_type}",
		# query_params={"origin_url": new_origin.url, "path": "baz"},
		# )

		# resp = check_html_get_response(
		# client, url, status_code=200, template_used=f"browse/{object_type}.html"
		# )
		# assert re.search("snapshot.*is empty", resp.content.decode("utf-8"))

		# def test_browse_directory_snapshot_not_found(client, mocker, origin):
		# mock_get_snapshot_context = mocker.patch(
		# "swh.web.browse.snapshot_context.get_snapshot_context"
		# )
		# mock_get_snapshot_context.side_effect = NotFoundExc("Snapshot not found")
		# url = reverse("browse-origin-directory",
		# query_params={"origin_url": origin["url"]})

		# resp = check_html_get_response(
		# client, url, status_code=404, template_used="error.html"
		# )
		# assert_contains(resp, "Snapshot not found", status_code=404)
		# assert mock_get_snapshot_context.called


		# @given(new_origin())
		# def test_origin_empty_snapshot(client, archive_data, new_origin):

		# _add_empty_snapshot_origin(new_origin, archive_data)

		# url = reverse(
		# "browse-origin-directory", query_params={"origin_url": new_origin.url}
		# )

		# resp = check_html_get_response(
		# client, url, status_code=200, template_used="browse/directory.html"
		# )
		# resp_content = resp.content.decode("utf-8")
		# assert re.search("snapshot.*is empty", resp_content)
		# assert not re.search("swh-tr-link", resp_content)


		def test_origin_sub_directory_view(client, archive_data, swh_scheduler, origin):
		origin_visits = archive_data.origin_visit_get(origin["url"])

		visit = origin_visits[-1]
		snapshot = archive_data.snapshot_get(visit["snapshot"])
		snapshot_sizes = archive_data.snapshot_count_branches(snapshot["id"])
		head_rev_id = archive_data.snapshot_get_head(snapshot)
		head_rev = archive_data.revision_get(head_rev_id)
		root_dir_sha1 = head_rev["directory"]
		subdirs = [
		e for e in archive_data.directory_ls(root_dir_sha1) if e["type"] == "dir"
		]
		branches, releases, _ = process_snapshot_branches(snapshot)

		if len(subdirs) == 0:
		return

		subdir = random.choice(subdirs)
		subdir_content = archive_data.directory_ls(subdir["target"])
		subdir_path = subdir["name"]

		_origin_directory_view_test_helper(
		client,
		archive_data,
		origin,
		visit,
		snapshot_sizes,
		branches,
		releases,
		root_dir_sha1,
		subdir_content,
		path=subdir_path,
		)

		# _origin_directory_view_test_helper(
		# client,
		# archive_data,
		# origin,
		# visit,
		# snapshot_sizes,
		# branches,
		# releases,
		# root_dir_sha1,
		# subdir_content,
		# path=subdir_path,
		# visit_id=visit["visit"],
		# )

		_origin_directory_view_test_helper(
		client,
		archive_data,
		origin,
		visit,
		snapshot_sizes,
		branches,
		releases,
		root_dir_sha1,
		subdir_content,
		path=subdir_path,
		timestamp=visit["date"],
		)

		# _origin_directory_view_test_helper(
		# client,
		# archive_data,
		# origin,
		# visit,
		# snapshot_sizes,
		# branches,
		# releases,
		# root_dir_sha1,
		# subdir_content,
		# path=subdir_path,
		# snapshot_id=visit["snapshot"],
		# )

		# _origin_directory_view_test_helper(
		# client,
		# archive_data,
		# origin,
		# visit,
		# snapshot_sizes,
		# branches,
		# releases,
		# root_dir_sha1,
		# subdir_content,
		# path=subdir_path,
		# )

		_origin_directory_view_test_helper(
		client,
		archive_data,
		origin,
		visit,
		snapshot_sizes,
		branches,
		releases,
		root_dir_sha1,
		subdir_content,
		path=subdir_path,
		visit_id=visit["visit"],
		)

		# _origin_directory_view_test_helper(
		# client,
		# archive_data,
		# origin,
		# visit,
		# snapshot_sizes,
		# branches,
		# releases,
		# root_dir_sha1,
		# subdir_content,
		# path=subdir_path,
		# timestamp=visit["date"],
		# )

		_origin_directory_view_test_helper(
		client,
		archive_data,
		origin,
		visit,
		snapshot_sizes,
		branches,
		releases,
		root_dir_sha1,
		subdir_content,
		path=subdir_path,
		snapshot_id=visit["snapshot"],
		)


		def test_origin_root_directory_view(client, archive_data, swh_scheduler, origin):
		origin_visits = archive_data.origin_visit_get(origin["url"])

		visit = origin_visits[-1]
		snapshot = archive_data.snapshot_get(visit["snapshot"])
		snapshot_sizes = archive_data.snapshot_count_branches(snapshot["id"])
		head_rev_id = archive_data.snapshot_get_head(snapshot)
		head_rev = archive_data.revision_get(head_rev_id)
		root_dir_sha1 = head_rev["directory"]
		dir_content = archive_data.directory_ls(root_dir_sha1)
		branches, releases, _ = process_snapshot_branches(snapshot)

		_origin_directory_view_test_helper(
		client,
		archive_data,
		origin,
		visit,
		snapshot_sizes,
		branches,
		releases,
		root_dir_sha1,
		dir_content,
		)

		_origin_directory_view_test_helper(
		client,
		archive_data,
		origin,
		visit,
		snapshot_sizes,
		branches,
		releases,
		root_dir_sha1,
		dir_content,
		visit_id=visit["visit"],
		)

		# _origin_directory_view_test_helper(
		# client,
		# archive_data,
		# origin,
		# visit,
		# snapshot_sizes,
		# branches,
		# releases,
		# root_dir_sha1,
		# dir_content,
		# timestamp=visit["date"],
		# )

		_origin_directory_view_test_helper(
		client,
		archive_data,
		origin,
		visit,
		snapshot_sizes,
		branches,
		releases,
		root_dir_sha1,
		dir_content,
		snapshot_id=visit["snapshot"],
		)

		_origin_directory_view_test_helper(
		client,
		archive_data,
		origin,
		visit,
		snapshot_sizes,
		branches,
		releases,
		root_dir_sha1,
		dir_content,
		)

		_origin_directory_view_test_helper(
		client,
		archive_data,
		origin,
		visit,
		snapshot_sizes,
		branches,
		releases,
		root_dir_sha1,
		dir_content,
		visit_id=visit["visit"],
		)

		# _origin_directory_view_test_helper(
		# client,
		# archive_data,
		# origin,
		# visit,
		# snapshot_sizes,
		# branches,
		# releases,
		# root_dir_sha1,
		# dir_content,
		# timestamp=visit["date"],
		# )

		_origin_directory_view_test_helper(
		client,
		archive_data,
		origin,
		visit,
		snapshot_sizes,
		branches,
		releases,
		root_dir_sha1,
		dir_content,
		snapshot_id=visit["snapshot"],
		)


		def _origin_directory_view_test_helper(
		client,
		archive_data,
		origin_info,
		origin_visit,
		snapshot_sizes,
		origin_branches,
		origin_releases,
		root_directory_sha1,
		directory_entries,
		visit_id=None,
		timestamp=None,
		snapshot_id=None,
		path=None,
		):
		dirs = [e for e in directory_entries if e["type"] in ("dir", "rev")]
		files = [e for e in directory_entries if e["type"] == "file"]

		if not visit_id and not snapshot_id:
		visit_id = origin_visit["visit"]

		query_params = {"origin_url": origin_info["url"]}

		if timestamp:
		query_params["timestamp"] = timestamp
		elif visit_id:
		query_params["visit_id"] = visit_id
		else:
		query_params["snapshot"] = snapshot_id

		if path:
		query_params["path"] = path

		url = reverse(
		"browse-directory",
		url_args={"sha1_git": root_directory_sha1},
		query_params=query_params,
		)

		resp = check_html_get_response(
		client, url, status_code=200, template_used="browse/directory.html"
		)

		assert_contains(resp, '<td class="swh-directory">', count=len(dirs))
		assert_contains(resp, '<td class="swh-content">', count=len(files))

		if timestamp:
		query_params["timestamp"] = format_utc_iso_date(
		parse_iso8601_date_to_utc(timestamp).isoformat(), "%Y-%m-%dT%H:%M:%SZ"
		)

		# for d in dirs:
		# if d["type"] == "rev":
		# dir_url = reverse("browse-revision", url_args={"sha1_git": d["target"]})
		# else:
		# dir_path = d["name"]
		# if path:
		# dir_path = "%s/%s" % (path, d["name"])
		# query_params["path"] = dir_path
		# dir_url = reverse("browse-directory", query_params=query_params,)
		# assert_contains(resp, dir_url)

		# for f in files:
		# file_path = f["name"]
		# if path:
		# file_path = "%s/%s" % (path, f["name"])
		# query_params["path"] = file_path
		# file_url = reverse("browse-origin-content", query_params=query_params)
		# assert_contains(resp, file_url)

		if "path" in query_params:
		del query_params["path"]

		# root_dir_branch_url = reverse("browse-origin-directory",
		# query_params=query_params)

		nb_bc_paths = 1
		if path:
		nb_bc_paths = len(path.split("/")) + 1

		assert_contains(resp, '<li class="swh-path">', count=nb_bc_paths)
		# assert_contains(
		# resp, '<a href="%s">%s</a>' % (root_dir_branch_url, root_directory_sha1[:7])
		# )

		# origin_branches_url = reverse("browse-origin-branches", query_params=query_params)

		# assert_contains(resp, f'href="{escape(origin_branches_url)}"')
		assert_contains(resp, f"Branches ({snapshot_sizes['revision']})")

		origin_releases_url = reverse("browse-origin-releases", query_params=query_params)

		nb_releases = len(origin_releases)
		if nb_releases > 0:
		assert_contains(resp, f'href="{escape(origin_releases_url)}"')
		assert_contains(resp, f"Releases ({snapshot_sizes['release']})")

		if path:
		query_params["path"] = path

		assert_contains(resp, '<li class="swh-branch">', count=len(origin_branches))

		# for branch in origin_branches:
		# query_params["branch"] = branch["name"]
		# root_dir_branch_url = reverse(
		# "browse-origin-directory", query_params=query_params
		# )

		# assert_contains(resp, '<a href="%s">' % root_dir_branch_url)

		assert_contains(resp, '<li class="swh-release">', count=len(origin_releases))

		query_params["branch"] = None
		for release in origin_releases:
		query_params["release"] = release["name"]
		root_dir_release_url = reverse(
		"browse-origin-directory", query_params=query_params
		)

		assert_contains(resp, 'href="%s"' % root_dir_release_url)

		assert_contains(resp, "vault-cook-directory")
		assert_contains(resp, "vault-cook-revision")

		snapshot = archive_data.snapshot_get(origin_visit["snapshot"])
		head_rev_id = archive_data.snapshot_get_head(snapshot)

		swhid_context = {
		"origin": origin_info["url"],
		"visit": gen_swhid(ObjectType.SNAPSHOT, snapshot["id"]),
		"anchor": gen_swhid(ObjectType.REVISION, head_rev_id),
		"path": f"/{path}" if path else None,
		}

		swh_dir_id = gen_swhid(
		ObjectType.DIRECTORY, directory_entries[0]["dir_id"], metadata=swhid_context
		)
		swh_dir_id_url = reverse("browse-swhid", url_args={"swhid": swh_dir_id})
		assert_contains(resp, swh_dir_id)
		assert_contains(resp, swh_dir_id_url)

		assert_contains(resp, "swh-take-new-snapshot")

		_check_origin_link(resp, origin_info["url"])

		assert_not_contains(resp, "swh-metadata-popover")


		def _check_origin_link(resp, origin_url):
		browse_origin_url = reverse(
		"browse-origin", query_params={"origin_url": origin_url}
		)
		assert_contains(resp, f'href="{browse_origin_url}"')


		# @given(
		# new_origin(), new_snapshot(min_size=4, max_size=4), visit_dates(),
		# )
		# def test_browse_directory_snapshot_null_branch(
		# client, archive_data, revisions_list, new_origin, new_snapshot, visit_dates,
		# ):
		# revisions = revisions_list(size=4)
		# snp_dict = new_snapshot.to_dict()
		# archive_data.origin_add([new_origin])
		# for i, branch in enumerate(snp_dict["branches"].keys()):
		# if i == 0:
		# snp_dict["branches"][branch] = None
		# else:
		# snp_dict["branches"][branch] = {
		# "target_type": "revision",
		# "target": hash_to_bytes(revisions[i - 1]),
		# }

		# archive_data.snapshot_add([Snapshot.from_dict(snp_dict)])
		# visit = archive_data.origin_visit_add(
		# [OriginVisit(origin=new_origin.url, date=visit_dates[0], type="git",)]
		# )[0]
		# visit_status = OriginVisitStatus(
		# origin=new_origin.url,
		# visit=visit.visit,
		# date=now(),
		# status="partial",
		# snapshot=snp_dict["id"],
		# )
		# archive_data.origin_visit_status_add([visit_status])

		# url = reverse(
		# "browse-directory", query_params={"origin_url": new_origin.url}
		# )

		# check_html_get_response(
		# client, url, status_code=200, template_used="error.html"
		# )


		@given(
		new_origin(), new_snapshot(min_size=4, max_size=4), visit_dates(),
		)
		def test_browse_directory_snapshot_invalid_branch(
		client, archive_data, revisions_list, new_origin, new_snapshot, visit_dates,
		):
		revisions = revisions_list(size=4)
		snp_dict = new_snapshot.to_dict()
		archive_data.origin_add([new_origin])
		for i, branch in enumerate(snp_dict["branches"].keys()):
		snp_dict["branches"][branch] = {
		"target_type": "revision",
		"target": hash_to_bytes(revisions[i]),
		}

		archive_data.snapshot_add([Snapshot.from_dict(snp_dict)])
		visit = archive_data.origin_visit_add(
		[OriginVisit(origin=new_origin.url, date=visit_dates[0], type="git",)]
		)[0]
		visit_status = OriginVisitStatus(
		origin=new_origin.url,
		visit=visit.visit,
		date=now(),
		status="full",
		snapshot=snp_dict["id"],
		)
		archive_data.origin_visit_status_add([visit_status])

		url = reverse(
		"browse-directory",
		query_params={"origin_url": new_origin.url, "branch": "invalid_branch"},
		)

		check_html_get_response(client, url, status_code=404, template_used="error.html")


		def test_browse_directory_no_visit(client, mocker, origin):
		mock_get_origin_visits = mocker.patch(
		"swh.web.common.origin_visits.get_origin_visits"
		)
		mock_get_origin_visits.return_value = []
		mock_archive = mocker.patch("swh.web.common.origin_visits.archive")
		mock_archive.lookup_origin_visit_latest.return_value = None
		url = reverse("browse-directory", query_params={"origin_url": origin["url"]})

		resp = check_html_get_response(
		client, url, status_code=404, template_used="error.html"
		)
		assert_contains(resp, "No valid visit", status_code=404)
		assert not mock_get_origin_visits.called


		def test_browse_directory_unknown_visit(client, mocker, origin):
		mock_get_origin_visits = mocker.patch(
		"swh.web.common.origin_visits.get_origin_visits"
		)
		mock_get_origin_visits.return_value = [{"visit": 1}]

		url = reverse(
		"browse-directory", query_params={"origin_url": origin["url"], "visit_id": 2},
		)

		resp = check_html_get_response(
		client, url, status_code=404, template_used="error.html"
		)
		assert re.search("Visit.*not found", resp.content.decode("utf-8"))
		assert mock_get_origin_visits.called


		def test_browse_origin_directory_not_found(client, origin):
		url = reverse(
		"browse-directory",
		query_params={"origin_url": origin["url"], "path": "/invalid/dir/path/"},
		)

		resp = check_html_get_response(
		client, url, status_code=404, template_used="error.html"
		)
		assert re.search(
		"Directory entry with path.*from root directory", resp.content.decode("utf-8")
		)


		@given(new_origin())
		def test_directory_browse_empty_snapshot_null_revision(
		client, archive_data, new_origin
		):
		snapshot = Snapshot(
		branches={
		b"HEAD": SnapshotBranch(
		target="refs/head/master".encode(), target_type=TargetType.ALIAS,
		),
		b"refs/head/master": None,
		}
		)
		archive_data.origin_add([new_origin])
		archive_data.snapshot_add([snapshot])
		visit = archive_data.origin_visit_add(
		[OriginVisit(origin=new_origin.url, date=now(), type="git",)]
		)[0]
		visit_status = OriginVisitStatus(
		origin=new_origin.url,
		visit=visit.visit,
		date=now(),
		status="partial",
		snapshot=snapshot.id,
		)
		archive_data.origin_visit_status_add([visit_status])

		url = reverse("browse-directory", query_params={"origin_url": new_origin.url},)

		resp = check_html_get_response(
		client, url, status_code=404, template_used="error.html"
		)
		resp_content = resp.content.decode("utf-8")

		assert re.search("The requested directory is not available", resp_content)


		def test_content_browse_empty_sha1_missing_identifier(client):
		url = reverse("browse-directory", query_params={},)
		resp = check_html_get_response(client, url, status_code=400)
		assert_contains(
		resp,
		"The origin_url or snapshot query parameter must be provided.",
		status_code=400,
		)


		def test_content_browse_empty_sha1(client, directory):
		url = reverse("browse-directory", query_params={"sha1_git": directory},)
		resp = check_html_get_response(client, url, status_code=302)
		redict_url = reverse(
		"browse-directory",
		url_args={"sha1_git": directory},
		query_params={"sha1_git": directory},
		)
		assert resp.url == redict_url


		def test_content_browse_empty_sha1_with_snapshot(client, snapshot, archive_data):
		head_branch = archive_data.snapshot_get_branches(snapshot)["branches"][
		"refs/heads/master"
		]["target"]
		directory = archive_data.revision_get(head_branch)["directory"]
		url = reverse("browse-directory", query_params={"snapshot": snapshot},)

		resp = check_html_get_response(client, url, status_code=302)

		redict_url = reverse(
		"browse-directory",
		url_args={"sha1_git": directory},
		query_params={"snapshot": snapshot},
		)
		assert resp.url == redict_url


		def test_content_browse_empty_sha1_with_origin(client, origin, archive_data):
		snapshot = archive_data.snapshot_get_latest(origin["url"])
		head_branch = archive_data.snapshot_get_branches(snapshot["id"])["branches"][
		"refs/heads/master"
		]["target"]
		directory = archive_data.revision_get(head_branch)["directory"]
		url = reverse("browse-directory", query_params={"origin_url": origin["url"]},)

		resp = check_html_get_response(client, url, status_code=302)

		redict_url = reverse(
		"browse-directory",
		url_args={"sha1_git": directory},
		query_params={"origin_url": origin["url"]},
		)
		assert resp.url == redict_url


		def test_browse_directory_release(client, archive_data, origin_with_releases):
		origin_url = origin_with_releases["url"]
		snapshot = archive_data.snapshot_get_latest(origin_url)
		release = [
		b for b in snapshot["branches"].values() if b["target_type"] == "release"
		][-1]
		release_data = archive_data.release_get(release["target"])
		revision_data = archive_data.revision_get(release_data["target"])
		url = reverse(
		"browse-directory",
		query_params={"origin_url": origin_url, "release": release_data["name"]},
		)
		resp = check_html_get_response(client, url, status_code=302)
		redirected_url = reverse(
		"browse-directory",
		url_args={"sha1_git": revision_data["directory"]},
		query_params={"origin_url": origin_url, "release": release_data["name"]},
		)

		assert resp.url == redirected_url

		resp = check_html_get_response(
		client, redirected_url, status_code=200, template_used="browse/directory.html"
		)

		assert_contains(resp, release_data["name"])
		assert_contains(resp, release["target"])

		swhid_context = {
		"origin": origin_url,
		"visit": gen_swhid(ObjectType.SNAPSHOT, snapshot["id"]),
		"anchor": gen_swhid(ObjectType.RELEASE, release_data["id"]),
		}

		swh_dir_id = gen_swhid(
		ObjectType.DIRECTORY, revision_data["directory"], metadata=swhid_context
		)
		swh_dir_id_url = reverse("browse-swhid", url_args={"swhid": swh_dir_id})
		assert_contains(resp, swh_dir_id)
		assert_contains(resp, swh_dir_id_url)


		def test_browse_directory_release_not_found(client, origin_with_releases):
		invalid_release_name = "swh-foo-bar"
		url = reverse(
		"browse-directory",
		query_params={
		"origin_url": origin_with_releases["url"],
		"release": invalid_release_name,
		},
		)

		resp = check_html_get_response(
		client, url, status_code=404, template_used="error.html"
		)

		assert re.search(
		f"Release {invalid_release_name}.*not found", resp.content.decode("utf-8")
		)


		@given(new_origin())
		def test_browse_directory_branch_with_non_resolvable_revision(
		client, archive_data, unknown_revision, new_origin,
		):
		branch_name = "master"
		snapshot = Snapshot(
		branches={
		branch_name.encode(): SnapshotBranch(
		target=hash_to_bytes(unknown_revision), target_type=TargetType.REVISION,
		)
		}
		)
		archive_data.origin_add([new_origin])
		archive_data.snapshot_add([snapshot])
		visit = archive_data.origin_visit_add(
		[OriginVisit(origin=new_origin.url, date=now(), type="git",)]
		)[0]
		visit_status = OriginVisitStatus(
		origin=new_origin.url,
		visit=visit.visit,
		date=now(),
		status="partial",
		snapshot=snapshot.id,
		)
		archive_data.origin_visit_status_add([visit_status])

		url = reverse(
		"browse-directory",
		query_params={"origin_url": new_origin.url, "branch": branch_name},
		)

		resp = check_html_get_response(
		client, url, status_code=404, template_used="error.html"
		)
		# FIXME, this could be a problem (just showing error page)
		assert re.search(
		"The requested directory is not available", resp.content.decode("utf-8")
		)


		def test_browse_pull_request_branch(
		client, archive_data, origin_with_pull_request_branches
		):
		origin_url = origin_with_pull_request_branches.url
		snapshot = archive_data.snapshot_get_latest(origin_url)
		pr_branch = random.choice(
		[
		branch
		for branch in snapshot["branches"].keys()
		if branch.startswith("refs/pull/")
		]
		)
		root_dir = archive_data.revision_get(snapshot["branches"][pr_branch]["target"])[
		"directory"
		]
		url = reverse(
		"browse-directory",
		url_args={"sha1_git": root_dir},
		query_params={"origin_url": origin_url, "branch": pr_branch},
		)
		# FIXME, is this correct behaviour?
		check_html_get_response(
		client, url, status_code=200, template_used="browse/directory.html"
		)