Changeset View
Standalone View
docs/package-loader-specifications.rst
| Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Lines | * - deposit | ||||||||
| - HEAD | - HEAD | ||||||||
| - only HEAD | - only HEAD | ||||||||
| - HEAD | - HEAD | ||||||||
| - "{client}: Deposit {id} in collection {collection}" | - "{client}: Deposit {id} in collection {collection}" | ||||||||
| - true | - true | ||||||||
| - SWH robot | - SWH robot | ||||||||
| - ``<codemeta: dateCreated>`` from SWORD XML | - ``<codemeta: dateCreated>`` from SWORD XML | ||||||||
| - revisions had parents | - revisions had parents | ||||||||
| * - maven-loader | |||||||||
| - passed as arg | |||||||||
| - HEAD | |||||||||
| - ``release_name(version)`` | |||||||||
vlorentz: this doesn't match the code; "standard message" is `f"Synthetic release for {PACKAGE_MANAGER}… | |||||||||
Done Inline ActionsChanged both to "Synthetic release for maven-loader at {p_info.url}\n". borisbaldassari: Changed both to "Synthetic release for maven-loader at {p_info.url}\n". | |||||||||
Done Inline ActionsI'd really prefer "Synthetic release for archive at {p_info.url}\n" over "Synthetic release for maven-loader at {p_info.url}\n", because it means the release was created from an archive (JAR is a type of archive), and that archive is located at the given URL. It's not meant to refer to the loader itself vlorentz: I'd really prefer `"Synthetic release for archive at {p_info.url}\n"` over `"Synthetic release… | |||||||||
Done Inline ActionsOk, no problem. Will do that Thursday (I'm busy until then). borisbaldassari: Ok, no problem. Will do that Thursday (I'm busy until then).
Sorry for misinterpreting your… | |||||||||
Done Inline Actions
ardumont: | |||||||||
| - "Synthetic release for archive at {p_info.url}\n" | |||||||||
| - true | |||||||||
Done Inline Actions
As vlorentz suggested, this should match the empty author. More generally, what you are documenting here should actually So please make sure it is ;) ardumont: As vlorentz suggested, this should match the empty author.
More generally, what you are… | |||||||||
Done Inline ActionsYes, I understand that specifications are supposed to be in sync with the code. I had changed the specs to use swh_person in order to be aligned with the maven loader and with other loaders (e.g. deposit) to ensure consistency. Don't understand what happened. Anyway, I've set the empty person in the loader, reverted my last change in the spec, and now everything is empty_author. borisbaldassari: Yes, I understand that specifications are supposed to be in sync with the code. I had changed… | |||||||||
| - "" | |||||||||
| - passed as arg | |||||||||
| - Only one artefact per url (jar/zip src) | |||||||||
| * - nixguix | * - nixguix | ||||||||
| - URL | - URL | ||||||||
| - URL | - URL | ||||||||
| - URL | - URL | ||||||||
| - "" | - "" | ||||||||
| - true | - true | ||||||||
| - "" | - "" | ||||||||
| - None | - None | ||||||||
| Show All 39 Lines | |||||||||
this doesn't match the code; "standard message" is f"Synthetic release for {PACKAGE_MANAGER} source package {name} version {version}\n", but in this loader's code, it's f"Synthetic release for Maven source package {p_info.url} gid {p_info.gid} aid {p_info.aid} version {p_info.version}\n"
What about replacing both with the Archive Loader's message? (ie. "Synthetic release for archive at {p_info.url}\n")