Changeset View
Changeset View
Standalone View
Standalone View
swh/web/tests/browse/views/test_origin.py
Show First 20 Lines • Show All 826 Lines • ▼ Show 20 Lines | assert_contains( | ||||
resp, "The path of a content must be given as query parameter.", status_code=400 | resp, "The path of a content must be given as query parameter.", status_code=400 | ||||
) | ) | ||||
def test_origin_views_no_url_query_parameter(client): | def test_origin_views_no_url_query_parameter(client): | ||||
for browse_context in ( | for browse_context in ( | ||||
"content", | "content", | ||||
"directory", | "directory", | ||||
"log", | |||||
"branches", | "branches", | ||||
"releases", | "releases", | ||||
"visits", | "visits", | ||||
): | ): | ||||
url = reverse(f"browse-origin-{browse_context}") | url = reverse(f"browse-origin-{browse_context}") | ||||
resp = check_html_get_response( | resp = check_html_get_response( | ||||
client, url, status_code=400, template_used="error.html" | client, url, status_code=400, template_used="error.html" | ||||
) | ) | ||||
assert_contains( | assert_contains( | ||||
resp, "An origin URL must be provided as query parameter.", status_code=400 | resp, "An origin URL must be provided as query parameter.", status_code=400, | ||||
) | |||||
anlambert: Please move the redirection check in a separate test. | |||||
@given(new_origin()) | |||||
@pytest.mark.parametrize("browse_context", ["log"]) | |||||
def test_origin_view_redirects(client, browse_context, new_origin): | |||||
query_params = {"origin_url": new_origin.url} | |||||
url = reverse(f"browse-origin-{browse_context}", query_params=query_params) | |||||
Done Inline ActionsThis test is not complete and can be improved, use this instead: @given(origin()) @pytest.mark.parametrize("browse_context", ["log"]) def test_origin_view_redirects(client, browse_context, origin): query_params = {"origin_url": origin["url"]} url = reverse(f"browse-origin-{browse_context}", query_params=query_params) resp = check_html_get_response(client, url, status_code=301) assert resp["location"] == reverse( f"browse-snapshot-{browse_context}", query_params=query_params ) anlambert: This test is not complete and can be improved, use this instead:
```lang=python
@given(origin… | |||||
Done Inline ActionsThis should be assert "/snapshot/{browse_context}/" in resp.url jayeshv: This should be assert "/snapshot/{browse_context}/" in resp.url
I will fix this with… | |||||
resp = check_html_get_response(client, url, status_code=301) | |||||
assert resp["location"] == reverse( | |||||
f"browse-snapshot-{browse_context}", query_params=query_params | |||||
) | |||||
@given(new_origin()) | |||||
@pytest.mark.parametrize("browse_context", ["log"]) | |||||
def test_origin_view_legacy_redirects(client, browse_context, new_origin): | |||||
params = {"origin_url": new_origin.url, "timestamp": "2021-01-23T22:24:10Z"} | |||||
url = reverse( | |||||
f"browse-origin-{browse_context}-legacy", url_args=params, query_params=params | |||||
) | |||||
resp = check_html_get_response(client, url, status_code=301) | |||||
assert resp["location"] == reverse( | |||||
f"browse-snapshot-{browse_context}", query_params=params | |||||
) | ) | ||||
def _origin_content_view_test_helper( | def _origin_content_view_test_helper( | ||||
client, | client, | ||||
archive_data, | archive_data, | ||||
origin_info, | origin_info, | ||||
origin_visit, | origin_visit, | ||||
snapshot_sizes, | snapshot_sizes, | ||||
▲ Show 20 Lines • Show All 462 Lines • Show Last 20 Lines |
Please move the redirection check in a separate test.