Page MenuHomeSoftware Heritage

loader-git: failure when saving git pack
Closed, ResolvedPublic

Description

Latest loader-git version got deployed and a shiny new error exists:

Sep 06 12:18:45 worker16 python3[904]: [2019-09-06 12:18:45,428: ERROR/ForkPoolWorker-9] Loading failure, updating to `partial` status
                                       Traceback (most recent call last):
                                         File "/usr/lib/python3/dist-packages/swh/loader/core/loader.py", line 873, inload
                                           self.store_data()
                                         File "/usr/lib/python3/dist-packages/swh/loader/core/loader.py", line 969, instore_data
                                           self.save_data()
                                         File "/usr/lib/python3/dist-packages/swh/loader/git/loader.py", line 337, in save_data
                                           pack_dir = self.get_save_data_path()
                                         File "/usr/lib/python3/dist-packages/swh/loader/core/loader.py", line 213, inget_save_data_path
                                           origin_url_hash = hashlib.sha1(self.origin['url']).hexdigest()
                                       TypeError: Unicode-objects must be encoded before hashing
Sep 06 12:18:45 worker16 python3[904]: [2019-09-06 12:18:45,456: INFO/ForkPoolWorker-9] Task swh.loader.git.tasks.UpdateGitRepository[40c0fe07-b7cb-4847-818a-02a257924637] succeeded in 2.1278265099972486s: {'status': 'failed'}

Probably introduced by 35992bf7a8fc869b45fbed00bd05a751e8209815

(This is within the scope of the loader-core but i only saw that error on loader-git)

Event Timeline

ardumont changed the task status from Open to Work in Progress.Sep 6 2019, 2:23 PM
ardumont claimed this task.
ardumont triaged this task as High priority.
ardumont created this task.
ardumont updated the task description. (Show Details)Sep 6 2019, 2:27 PM
ardumont renamed this task from loader-git failure to loader-git: failure when trying to save data package.Sep 6 2019, 2:33 PM
ardumont renamed this task from loader-git: failure when trying to save data package to loader-git: failure when trying to save git pack.Sep 6 2019, 9:18 PM
ardumont renamed this task from loader-git: failure when trying to save git pack to loader-git: failure when saving git pack.
ardumont closed this task as Resolved.Sep 6 2019, 9:23 PM