Page MenuHomeSoftware Heritage
Files F9311972

No OneTemporary
Actions

View Options

diff --git a/swh/loader/package/cpan/loader.py b/swh/loader/package/cpan/loader.py
index b9d7fab..37d3ee5 100644
--- a/swh/loader/package/cpan/loader.py
+++ b/swh/loader/package/cpan/loader.py
@@ -1,179 +1,135 @@
# Copyright (C) 2022 The Software Heritage developers
# See the AUTHORS file at the top-level directory of this distribution
# License: GNU General Public License version 3, or any later version
# See top-level LICENSE file for more information
from datetime import datetime
-import json
import logging
-from pathlib import Path
from typing import Any, Dict, Iterator, List, Optional, Sequence, Tuple
import attr
import iso8601
from packaging.version import parse as parse_version
-import yaml
from swh.loader.package.loader import BasePackageInfo, PackageLoader
from swh.loader.package.utils import EMPTY_AUTHOR, Person, release_name
from swh.model.model import ObjectType, Release, Sha1Git, TimestampWithTimezone
from swh.storage.interface import StorageInterface
logger = logging.getLogger(__name__)
@attr.s
class CpanPackageInfo(BasePackageInfo):
name = attr.ib(type=str)
"""Name of the package"""
version = attr.ib(type=str)
"""Current version"""
last_modified = attr.ib(type=datetime)
"""File last modified date as release date."""
author = attr.ib(type=Person)
"""Author"""
-def extract_intrinsic_metadata(dir_path: Path) -> Dict[str, Any]:
- """Extract intrinsic metadata from META.json file at dir_path.
-
- Most Perl package version have a META.json file at the root of the archive,
- or a META.yml for older version.
-
- See https://perldoc.perl.org/CPAN::Meta for META specifications.
-
- Args:
- dir_path: A directory on disk where a META.json|.yml can be found
-
- Returns:
- A dict mapping from yaml parser
- """
- meta_json_path = dir_path / "META.json"
- meta_yml_path = dir_path / "META.yml"
- metadata: Dict[str, Any] = {}
- if meta_json_path.exists():
- metadata = json.loads(meta_json_path.read_text())
- elif meta_yml_path.exists():
- metadata = yaml.safe_load(meta_yml_path.read_text())
-
- return metadata
-
-
class CpanLoader(PackageLoader[CpanPackageInfo]):
visit_type = "cpan"
def __init__(
self,
storage: StorageInterface,
url: str,
api_base_url: str,
artifacts: List[Dict[str, Any]],
module_metadata: List[Dict[str, Any]],
**kwargs,
):
super().__init__(storage=storage, url=url, **kwargs)
self.url = url
self.api_base_url = api_base_url
self.artifacts: Dict[str, Dict] = {
artifact["version"]: {k: v for k, v in artifact.items() if k != "version"}
for artifact in artifacts
}
self.module_metadata: Dict[str, Dict] = {
meta["version"]: meta for meta in module_metadata
}
def get_versions(self) -> Sequence[str]:
"""Get all released versions of a Perl package
Returns:
A sequence of versions
Example::
["0.1.1", "0.10.2"]
"""
versions = list(self.artifacts.keys())
versions.sort(key=parse_version)
return versions
def get_default_version(self) -> str:
"""Get the newest release version of a Perl package
Returns:
A string representing a version
Example::
"0.10.2"
"""
return self.get_versions()[-1]
def get_package_info(self, version: str) -> Iterator[Tuple[str, CpanPackageInfo]]:
"""Get release name and package information from version
Args:
version: Package version (e.g: "0.1.0")
Returns:
Iterator of tuple (release_name, p_info)
"""
artifact = self.artifacts[version]
metadata = self.module_metadata[version]
last_modified = iso8601.parse_date(metadata["date"])
author = (
Person.from_fullname(metadata["author"].encode())
if metadata["author"]
else EMPTY_AUTHOR
)
p_info = CpanPackageInfo(
name=metadata["name"],
filename=artifact["filename"],
url=artifact["url"],
version=version,
last_modified=last_modified,
author=author,
checksums=artifact["checksums"],
)
yield release_name(version), p_info
def build_release(
self, p_info: CpanPackageInfo, uncompressed_path: str, directory: Sha1Git
) -> Optional[Release]:
- # Extract intrinsic metadata from uncompressed_path/META.json|.yml
- intrinsic_metadata = extract_intrinsic_metadata(
- Path(uncompressed_path) / f"{p_info.name}-{p_info.version}"
- )
-
- # author data from http endpoint are less complete than from META
- if "author" in intrinsic_metadata:
- author_data = intrinsic_metadata["author"]
- if type(author_data) is list:
- author = author_data[0]
- else:
- author = author_data
- author = Person.from_fullname(author.encode())
- else:
- author = p_info.author
-
message = (
f"Synthetic release for Perl source package {p_info.name} "
f"version {p_info.version}\n"
)
return Release(
name=p_info.version.encode(),
- author=author,
+ author=p_info.author,
date=TimestampWithTimezone.from_datetime(p_info.last_modified),
message=message.encode(),
target_type=ObjectType.DIRECTORY,
target=directory,
synthetic=True,
)

File Metadata

Mime Type
text/x-diff
Expires
Thu, Jul 3, 10:38 AM (2 w, 2 d ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
3252285

Event Timeline

About · Developer information · Legal