Page MenuHomeSoftware Heritage
Differential D993

Simplify a bit unit tests
ClosedPublic
Actions

Authored by douardda on Jan 24 2019, 10:24 AM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T1386: Refactor indexers' initialization step
Commits
rDCIDX99664da72219: Simplify a bit unit tests
Summary

passing the configuration of Indexer objects to the constructor instead
or overloading the parce_config_file in subclasses.

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jan 24 2019, 10:24 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 24 2019, 10:24 AM
swh-public-ci added a subscriber: swh-public-ci.Jan 24 2019, 10:27 AM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/255/ for more details.

Harbormaster completed remote builds in B3668: Diff 3143.Jan 24 2019, 10:27 AM
ardumont accepted this revision.Jan 24 2019, 10:38 AM
ardumont added a subscriber: ardumont.

Thanks

This revision is now accepted and ready to land.Jan 24 2019, 10:38 AM
douardda mentioned this in D986: Add a new indexer that combines all metadata-related indexers in a single task..Jan 24 2019, 5:28 PM
douardda updated this revision to Diff 3182.Jan 24 2019, 5:48 PM

rebased

Closed by commit rDCIDX99664da72219: Simplify a bit unit tests (authored by douardda). · Explain WhyJan 24 2019, 5:49 PM
This revision was automatically updated to reflect the committed changes.
swh-public-ci added a comment.Jan 24 2019, 5:51 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/269/ for more details.

Harbormaster completed remote builds in B3715: Diff 3182.Jan 24 2019, 5:51 PM
vlorentz added a task: T1386: Refactor indexers' initialization step.Jan 25 2019, 10:22 AM

Revision Contents
Changeset List

PathSize
swh/
indexer/
tests/
61 lines
76 lines
49 lines
74 lines
34 lines

Diff 3190

View Options

swh/indexer/tests/test_ctags.py

Loading...
View Options

swh/indexer/tests/test_fossology_license.py

Loading...
View Options

swh/indexer/tests/test_language.py

Loading...
View Options

swh/indexer/tests/test_mimetype.py

Loading...
View Options

swh/indexer/tests/utils.py

Loading...
About · Developer information · Legal