Page MenuHomeSoftware Heritage
Differential D958

storage: Add origin_get_range method to list all archived origins
ClosedPublic
Actions

Authored by anlambert on Jan 16 2019, 11:01 AM.

Details

Reviewers
olasd
vlorentz
Group Reviewers
Reviewers
Commits
rDSTOC76d7838c01e5: storage: Add origin_get_range method to list all archived origins
R65:76d7838c01e5: storage: Add origin_get_range method to list all archived origins
rDSTO76d7838c01e5: storage: Add origin_get_range method to list all archived origins
Summary

Add a new method to the storage interface in order to list all archived
origins in a paginated way.

Related T1399

Diff Detail

Repository
rDSTO Storage manager
Branch
storage-origins-get
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3581
Build 4650: tox-on-jenkinsJenkins
Build 4649: arc lint + arc unit

Event Timeline

anlambert created this revision.Jan 16 2019, 11:01 AM
anlambert added a reviewer: Reviewers.Jan 16 2019, 11:02 AM
swh-public-ci added a subscriber: swh-public-ci.Jan 16 2019, 11:05 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/156/ for more details.

Harbormaster completed remote builds in B3555: Diff 3049.Jan 16 2019, 11:05 AM
anlambert added a child revision: D959: Web API: Add endpoint to list all archived software origins.Jan 16 2019, 12:04 PM
vlorentz accepted this revision as: vlorentz.Jan 16 2019, 6:13 PM
vlorentz added a subscriber: vlorentz.

You should rename origins_get to origin_get_range, for consistance with content_get_range.

And it could use more testing of edge cases for origin_from.

Other than that, lgtm

This revision is now accepted and ready to land.Jan 16 2019, 6:13 PM
anlambert added a comment.Jan 17 2019, 10:40 AM

Ack, will update accordingly before landing that diff.

anlambert updated this revision to Diff 3069.Jan 17 2019, 11:44 AM

Update:

  • rename new method to origin_get_range
  • improve unit test
anlambert retitled this revision from storage: Add origins_get method to list all archived origins to storage: Add origin_get_range method to list all archived origins.Jan 17 2019, 11:44 AM
swh-public-ci added a comment.Jan 17 2019, 11:47 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/159/ for more details.

Harbormaster completed remote builds in B3578: Diff 3069.Jan 17 2019, 11:47 AM
anlambert updated this revision to Diff 3072.Jan 17 2019, 11:51 AM

Update: simplify test in in_memory.storage.origin_get_range

swh-public-ci added a comment.Jan 17 2019, 11:54 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/160/ for more details.

Harbormaster completed remote builds in B3581: Diff 3072.Jan 17 2019, 11:54 AM
Closed by commit rDSTO76d7838c01e5: storage: Add origin_get_range method to list all archived origins (authored by anlambert). · Explain WhyJan 17 2019, 12:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
storage/
api/
4 lines
6 lines
20 lines
22 lines
23 lines
tests/
34 lines
39 lines

Diff 3072

View Options

swh/storage/api/client.py

Loading...
View Options

swh/storage/api/server.py

Loading...
View Options

swh/storage/db.py

Loading...
View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/storage.py

Loading...
View Options

swh/storage/tests/generate_data_test.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal