Differential D951

Fix normalization of npm's 'repository' and 'bugs' fields.
ClosedPublic
Actions

Authored by vlorentz on Jan 15 2019, 2:31 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T1385: Monitor output of metadata indexers

Commits

rDCIDXba847fee7c03: Fix normalization of npm's 'repository' and 'bugs' fields.

Summary

And add tests.

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 15 2019, 2:31 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 15 2019, 2:31 PM

ardumont added a subscriber: ardumont.Jan 15 2019, 2:34 PM

ardumont added inline comments.

swh/indexer/metadata_dictionary.py
199	We got a discussion a while back where the consensus was, use one return statement per method/function ;)

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/208/ for more details.

Harbormaster completed remote builds in B3486: Diff 2989.Jan 15 2019, 2:39 PM

vlorentz added a task: T1385: Monitor output of metadata indexers.Jan 15 2019, 3:57 PM

Other than the remark from earlier, it's fine.

This revision is now accepted and ready to land.Jan 15 2019, 4:59 PM

rebase

Closed by commit rDCIDXba847fee7c03: Fix normalization of npm's 'repository' and 'bugs' fields. (authored by vlorentz). · Explain WhyJan 15 2019, 5:01 PM

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B3522: Diff 3020!Jan 15 2019, 5:01 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/216/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/216/console

Revision Contents
Changeset List

Path

Size

swh/

indexer/

metadata_dictionary.py

24 lines

tests/

test_metadata.py

110 lines

Diff 3021

View Options

swh/indexer/metadata_dictionary.py