Differential D950

Prevent license normalization from crashing on malformed input.
ClosedPublic
Actions

Authored by vlorentz on Jan 15 2019, 2:30 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T1385: Monitor output of metadata indexers

Commits

rDCIDXd40cb1a4b914: Prevent license normalization from crashing on malformed input.

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 15 2019, 2:30 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 15 2019, 2:30 PM

ardumont added a subscriber: ardumont.Jan 15 2019, 2:31 PM

ardumont added inline comments.

swh/indexer/metadata_dictionary.py
226	return {"@id": "https://spdx.org/licenses/" + s} if isinstance(s, str) else None ?

ardumont accepted this revision.Jan 15 2019, 2:33 PM

This revision is now accepted and ready to land.Jan 15 2019, 2:33 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/206/ for more details.

Harbormaster completed remote builds in B3485: Diff 2988.Jan 15 2019, 2:33 PM

vlorentz marked an inline comment as done.Jan 15 2019, 3:47 PM

vlorentz added inline comments.

swh/indexer/metadata_dictionary.py
226	shrugs I'm not a huge fan of ternaries outside generator expressions

vlorentz added a task: T1385: Monitor output of metadata indexers.Jan 15 2019, 3:57 PM

rebase

Closed by commit rDCIDXd40cb1a4b914: Prevent license normalization from crashing on malformed input. (authored by vlorentz). · Explain WhyJan 15 2019, 5:01 PM

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B3520: Diff 3018!Jan 15 2019, 5:01 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/215/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/215/console

Revision Contents
Changeset List

Path

Size

swh/

indexer/

metadata_dictionary.py

9 lines

Diff 3019

View Options

swh/indexer/metadata_dictionary.py

Prevent license normalization from crashing on malformed input.ClosedPublicActions