Page MenuHomeSoftware Heritage
Differential D944

Use full postgresql connexion URLs everywhere
ClosedPublic
Actions

Authored by douardda on Jan 14 2019, 1:16 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDENVe1d3e4241823: Use full postgresql connexion URLs everywhere
rCDFDe1d3e4241823: Use full postgresql connexion URLs everywhere
Summary

Depends on D943

Diff Detail

Repository
rCDFD Dockerfiles for developers
Branch
loaders
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 3530
Build 4572: arc lint + arc unit

Event Timeline

douardda created this revision.Jan 14 2019, 1:16 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 14 2019, 1:16 PM
Harbormaster completed remote builds in B3467: Diff 2971.Jan 14 2019, 1:16 PM
douardda added a child revision: D945: Rename celery workers as <swh-instance>@<hostname>.Jan 14 2019, 1:17 PM
vlorentz added a subscriber: vlorentz.Jan 14 2019, 1:21 PM

Why?

ardumont added a subscriber: ardumont.EditedJan 14 2019, 2:18 PM

Why?

I'd say for informational and consistency purposes ;)
I for one, prefer this declarative form (service=swh) which i did not know i could use that way (with the sqlalchemy thing).

ardumont accepted this revision.Jan 14 2019, 2:23 PM
This revision is now accepted and ready to land.Jan 14 2019, 2:23 PM
douardda updated this revision to Diff 3028.Jan 15 2019, 5:19 PM

rebased

Harbormaster completed remote builds in B3530: Diff 3028.Jan 15 2019, 5:19 PM
douardda added a comment.Jan 15 2019, 5:26 PM
In D944#20063, @ardumont wrote:

Why?

I'd say for informational and consistency purposes ;)
I for one, prefer this declarative form (service=swh) which i did not know i could use that way (with the sqlalchemy thing).

Yes, I wanted all pg cnx strings to be consistent. And I picked the URI syntax. URI everywhere!

Closed by commit rCDFDe1d3e4241823: Use full postgresql connexion URLs everywhere (authored by douardda). · Explain WhyJan 15 2019, 5:33 PM
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDENVe1d3e4241823: Use full postgresql connexion URLs everywhere.Nov 26 2019, 1:35 PM

Revision Contents
Changeset List

PathSize
dockerfiles/
swh-deposit/
2 lines
swh-indexer-storage/
2 lines
2 lines
swh-loaders-worker/
2 lines
swh-scheduler-api/
2 lines
swh-scheduler-worker/
2 lines
swh-storage-listener/
2 lines
2 lines
swh-storage/
2 lines
4 lines

Diff 3028

View Options

dockerfiles/swh-deposit/entrypoint.sh

Loading...
View Options

dockerfiles/swh-indexer-storage/entrypoint.sh

Loading...
View Options

dockerfiles/swh-indexer-storage/indexer_storage.yml

Loading...
View Options

dockerfiles/swh-loaders-worker/loader.yml

Loading...
View Options

dockerfiles/swh-scheduler-api/entrypoint.sh

Loading...
View Options

dockerfiles/swh-scheduler-worker/scheduler.yml

Loading...
View Options

dockerfiles/swh-storage-listener/entrypoint.sh

Loading...
View Options

dockerfiles/swh-storage-listener/listener.yml

Loading...
View Options

dockerfiles/swh-storage/entrypoint.sh

Loading...
View Options

dockerfiles/swh-storage/storage.yml

Loading...
About · Developer information · Legal