Paths

Table of Contentst

Differential D928

Add a 'search in metadata' checkbox in the origin search.
ClosedPublic
Actions

Authored by vlorentz on Jan 11 2019, 4:10 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

R65:782a58ef84f2: Add a 'search in metadata' checkbox in the origin search.
rDWAPPS782a58ef84f2: Add a 'search in metadata' checkbox in the origin search.

Summary

Depends on D927.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 11 2019, 4:10 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 11 2019, 4:10 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/102/ for more details.

Harbormaster completed remote builds in B3434: Diff 2943.Jan 11 2019, 4:13 PM

anlambert accepted this revision.Jan 11 2019, 4:17 PM

anlambert added a subscriber: anlambert.

anlambert added inline comments.

swh/web/assets/src/bundles/browse/origin-search.js
92	debug statement here
180	I would call that parameter `search_metadata` instead (shorter and we known that we are searching origins)

This revision is now accepted and ready to land.Jan 11 2019, 4:17 PM

Apply @anlambert's comments.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/104/ for more details.

Harbormaster completed remote builds in B3436: Diff 2945.Jan 11 2019, 4:23 PM

rebase + squash

Closed by commit rDWAPPS782a58ef84f2: Add a 'search in metadata' checkbox in the origin search. (authored by vlorentz). · Explain WhyJan 11 2019, 4:23 PM

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B3440: Diff 2948!Jan 11 2019, 4:23 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/106/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/106/console

Revision Contents
Changeset List

Path

Size

swh/

web/

assets/

src/

bundles/

browse/

origin-search.js

31 lines

templates/

browse/

search.html

5 lines

Diff 2949

View Options

swh/web/assets/src/bundles/browse/origin-search.js