Page MenuHomeSoftware Heritage
Differential D928

Add a 'search in metadata' checkbox in the origin search.
ClosedPublic
Actions

Authored by vlorentz on Jan 11 2019, 4:10 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
R65:782a58ef84f2: Add a 'search in metadata' checkbox in the origin search.
rDWAPPS782a58ef84f2: Add a 'search in metadata' checkbox in the origin search.
Summary

Depends on D927.

Diff Detail

Repository
rDWAPPS Web applications
Branch
search-in-metadata-ui
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3436
Build 4429: tox-on-jenkinsJenkins
Build 4428: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jan 11 2019, 4:10 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 11 2019, 4:10 PM
swh-public-ci added a subscriber: swh-public-ci.Jan 11 2019, 4:13 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/102/ for more details.

Harbormaster completed remote builds in B3434: Diff 2943.Jan 11 2019, 4:13 PM
anlambert accepted this revision.Jan 11 2019, 4:17 PM
anlambert added a subscriber: anlambert.
anlambert added inline comments.
swh/web/assets/src/bundles/browse/origin-search.js
92

debug statement here

180

I would call that parameter search_metadata instead (shorter and we known that we are searching origins)

This revision is now accepted and ready to land.Jan 11 2019, 4:17 PM
vlorentz updated this revision to Diff 2945.Jan 11 2019, 4:20 PM
swh-public-ci added a comment.Jan 11 2019, 4:23 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/104/ for more details.

Harbormaster completed remote builds in B3436: Diff 2945.Jan 11 2019, 4:23 PM
vlorentz updated this revision to Diff 2948.Jan 11 2019, 4:23 PM
  • rebase + squash
Closed by commit rDWAPPS782a58ef84f2: Add a 'search in metadata' checkbox in the origin search. (authored by vlorentz). · Explain WhyJan 11 2019, 4:23 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B3440: Diff 2948!Jan 11 2019, 4:23 PM
swh-public-ci added a comment.Jan 11 2019, 4:24 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/106/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/106/console

Revision Contents
Changeset List

PathSize
swh/
web/
assets/
src/
bundles/
browse/
31 lines
templates/
browse/
5 lines

Diff 2945

View Options

swh/web/assets/src/bundles/browse/origin-search.js

Loading...
View Options

swh/web/templates/browse/search.html

Loading...
About · Developer information · Legal