Differential D913

Add a --priority cmdline option to the 'swh-scheduler task add' tool
ClosedPublic
Actions

Authored by douardda on Jan 10 2019, 3:54 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSCH996e9050730a: Add a --priority cmdline option to the 'swh-scheduler task add' tool

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jan 10 2019, 3:54 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 10 2019, 3:54 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/77/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/77/console

Harbormaster failed remote builds in B3373: Diff 2896!Jan 10 2019, 3:58 PM

ardumont added a subscriber: ardumont.Jan 10 2019, 4:51 PM

ardumont added inline comments.

swh/scheduler/cli.py
208	None is actually a value too. currently, recurring by default do not have a priority at all.

ardumont added inline comments.Jan 10 2019, 4:53 PM

swh/scheduler/cli.py
208	recurring tasks*

ardumont requested changes to this revision.Jan 11 2019, 12:11 PM

ardumont added inline comments.

swh/scheduler/cli.py
208	To match the actual behavior, as the policy default to recurring, the default of priority matching is None.

This revision now requires changes to proceed.Jan 11 2019, 12:11 PM

set priority default value to None

ardumont accepted this revision.Jan 14 2019, 11:32 AM

This revision is now accepted and ready to land.Jan 14 2019, 11:32 AM

Closed by commit rDSCH996e9050730a: Add a --priority cmdline option to the 'swh-scheduler task add' tool (authored by douardda). · Explain WhyJan 14 2019, 11:34 AM

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B3446: Diff 2952!Jan 14 2019, 11:34 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/78/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/78/console

Revision Contents
Changeset List

Path

Size

swh/

scheduler/

cli.py

9 lines

Diff 2953

View Options

Add a --priority cmdline option to the 'swh-scheduler task add' toolClosedPublicActions