jobs/templates: Add GitLab suport for debian packages related jobs
ClosedPublic
Actions

Authored by anlambert on Jan 4 2023, 12:23 PM.

Details

Reviewers

ardumont

Group Reviewers

System administrators

Commits

Summary

SWH migration to GitLab is incoming and we are not using elastic workers
yet in production so we still need to build debian packages for swh modules.

So add support for building the debian packages when pushing tags to swh
module repositories hosted on GitLab.

Repository

rCJSWH Jenkins jobs

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

anlambert requested review of this revision.Jan 4 2023, 12:23 PM

SWH migration to GitLab is incoming and we are not using elastic workers
yet in production so we still need to build debian packages for swh modules.

But even when it will be wired, we'll still need those for the rpc services that
will need to be wired at some point too.

jobs/templates/debian/gbp-buildpackage.yaml
5	maybe that stuff could be moved to the global default you defined somewhere in another diff too?
jobs/templates/incoming-tag.groovy.j2
60–61	why do we need a substring of that source branch? (maybe add a comment to explain it)

lgtm

Couple of remarks/questions inline.

This revision is now accepted and ready to land.Jan 4 2023, 2:04 PM

jobs/templates/debian/gbp-buildpackage.yaml
5	I planned to remove all stuffs related to Phabricator once we migrated to GitLab so not sure we need such refactoring as this will go away.
jobs/templates/incoming-tag.groovy.j2
60–61	To remove the `refs/tags/`prefix, I should have added a comment indeed.

jobs/templates/debian/gbp-buildpackage.yaml
5	Yes, ok. I refrain from saying anything else in the other if/else instructions in the diff for that reason too. This one, I mentioned as at least it will centralize rather simply the change now, and then that becomes only one removal for that once we have migrated to gitlab. But fine either way.