Page MenuHomeSoftware Heritage
Differential D8986

Return a list of persons for author and committer fields
ClosedPublic
Actions

Authored by jayeshv on Dec 26 2022, 11:59 AM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDGQL413b4c733c28: Return a list of persons for author and committer fields
Summary

Author and committer in revision and author in release are now
returning a single person object. Change that to a list
of persons to support multiple authors in the data model.

Diff Detail

Repository
rDGQL GraphQL API
Branch
persons-list-D8986
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 33356
Build 52286: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 52285: arc lint + arc unit

Event Timeline

jayeshv created this revision.Dec 26 2022, 11:59 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 26 2022, 11:59 AM
swh-public-ci added a comment.Dec 26 2022, 12:01 PM

Build is green

Patch application report for D8986 (id=32367)

Rebasing onto 419b841366...

Current branch diff-target is up to date.
Changes applied before test
commit d7bda82d9b63498fea1d64ffd00ab6d6209c5089
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Dec 26 11:19:13 2022 +0100

    Return a list of persons for author and committer fields
    
    Author and committer in revision and author in release are now
    returning a single person object. Change that to a list
    of persons to support multiple authors in the data model.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/270/ for more details.

Harbormaster completed remote builds in B33353: Diff 32367.Dec 26 2022, 12:01 PM
jayeshv requested review of this revision.Dec 26 2022, 12:01 PM
jayeshv updated this revision to Diff 32370.Dec 26 2022, 2:25 PM

rebase

swh-public-ci added a comment.Dec 26 2022, 2:27 PM

Build is green

Patch application report for D8986 (id=32370)

Rebasing onto f6b5a2d5e5...

Current branch diff-target is up to date.
Changes applied before test
commit 750a6c51656c46b5b4def761f3841a3bbdca25ca
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Dec 26 11:19:13 2022 +0100

    Return a list of persons for author and committer fields
    
    Author and committer in revision and author in release are now
    returning a single person object. Change that to a list
    of persons to support multiple authors in the data model.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/272/ for more details.

Harbormaster completed remote builds in B33356: Diff 32370.Dec 26 2022, 2:28 PM
vlorentz accepted this revision.Jan 2 2023, 12:05 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/graphql/resolvers/person.py
16–17

you can make these types more specific

29

here, and the other _get_results below too

This revision is now accepted and ready to land.Jan 2 2023, 12:05 PM
jayeshv updated this revision to Diff 32378.Jan 2 2023, 12:11 PM

improve trye hints

jayeshv marked 2 inline comments as done.Jan 2 2023, 12:11 PM
swh-public-ci added a comment.Jan 2 2023, 12:12 PM

Build has FAILED

Patch application report for D8986 (id=32378)

Rebasing onto f6b5a2d5e5...

Current branch diff-target is up to date.
Changes applied before test
commit 908921fc7467f720454e1734f2132309012d48d9
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Dec 26 11:19:13 2022 +0100

    Return a list of persons for author and committer fields
    
    Author and committer in revision and author in release are now
    returning a single person object. Change that to a list
    of persons to support multiple authors in the data model.

Link to build: https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/278/
See console output for more information: https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/278/console

Harbormaster failed remote builds in B33364: Diff 32378!Jan 2 2023, 12:12 PM
jayeshv updated this revision to Diff 32379.Jan 2 2023, 12:15 PM

mypy fix

swh-public-ci added a comment.Jan 2 2023, 12:17 PM

Build is green

Patch application report for D8986 (id=32379)

Rebasing onto f6b5a2d5e5...

Current branch diff-target is up to date.
Changes applied before test
commit 413b4c733c2804ec0e2f97ce85ac0281f4f43f76
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Dec 26 11:19:13 2022 +0100

    Return a list of persons for author and committer fields
    
    Author and committer in revision and author in release are now
    returning a single person object. Change that to a list
    of persons to support multiple authors in the data model.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/279/ for more details.

Harbormaster completed remote builds in B33365: Diff 32379.Jan 2 2023, 12:17 PM
Closed by commit rDGQL413b4c733c28: Return a list of persons for author and committer fields (authored by jayeshv). · Explain WhyJan 2 2023, 12:18 PM
This revision was automatically updated to reflect the committed changes.
jayeshv added a commit: rDGQL413b4c733c28: Return a list of persons for author and committer fields.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
graphql/
resolvers/
68 lines100%
Loading...
4 lines100%
Loading...
21 lines100%
Loading...
schema/
10 lines--
tests/
functional/
14 lines100%
Loading...
24 lines100%
Loading...

Diff 32370

View Options

swh/graphql/resolvers/person.py

Loading...
View Options

swh/graphql/resolvers/resolver_factory.py

Loading...
View Options

swh/graphql/resolvers/resolvers.py

Loading...
View Options

swh/graphql/schema/schema.graphql

Loading...
View Options

swh/graphql/tests/functional/test_release_node.py

Loading...
View Options

swh/graphql/tests/functional/test_revision.py

Loading...
About · Developer information · Legal