Differential D8956

Fix crash on non-UTF8 branch names
ClosedPublic
Actions

Authored by vlorentz on Dec 13 2022, 1:23 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T4724: UnicodeDecodeError on branch names in git loader

Commits

rDLDG5018c6ad5be6: Fix crash on non-UTF8 branch names

Summary

Resolves T4724.

Diff Detail

Repository

rDLDG Git loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 33220
Build 52086: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 52085: arc lint + arc unit

Event Timeline

vlorentz created this revision.Dec 13 2022, 1:23 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 13 2022, 1:23 PM

Build is green

Patch application report for D8956 (id=32264)

Rebasing onto 92d9ada9b7...

Current branch diff-target is up to date.

Changes applied before test

commit 5018c6ad5be6a899bb81bcf0db33fe0d42c4ff02
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Dec 13 13:22:21 2022 +0100

    Fix crash on non-UTF8 branch names

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/245/ for more details.

Harbormaster completed remote builds in B33220: Diff 32264.Dec 13 2022, 1:26 PM

vlorentz requested review of this revision.Dec 13 2022, 1:26 PM

anlambert accepted this revision.Dec 13 2022, 1:27 PM

This revision is now accepted and ready to land.Dec 13 2022, 1:27 PM

Closed by commit rDLDG5018c6ad5be6: Fix crash on non-UTF8 branch names (authored by vlorentz). · Explain WhyDec 13 2022, 1:35 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDG5018c6ad5be6: Fix crash on non-UTF8 branch names.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

loader/

git/

loader.py

6 lines

87%

tests/

test_loader.py

2 lines

99%

Diff 32264

View Options

swh/loader/git/loader.py