Page MenuHomeSoftware Heritage
Differential D8955

utils: Fix unquoted SWHID URLs generated by get_swhids_info
ClosedPublic
Actions

Authored by anlambert on Dec 12 2022, 5:18 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDWAPPS415867e6021e: cypress: Fix flaky test
rDWAPPSd6a6c484d289: package.json: Upgrade dependencies
rDWAPPS62e965a34229: browse/iframe: Fix unquoted SWHID URLs in iframe views
rDWAPPS473583b6ce5b: utils: Fix unquoted SWHID URLs generated by get_swhids_info
Summary

As a SWHID with qualifiers might have some percent encoded characters (like ;
which is used as separator between qualifiers) and HTTP servers will unquote
received URL arguments, a SWHID must also be percent encoded when used as an
URL argument.

This prevent HTTP errors when trying to browse such SWHIDs as previously the
unquoting performed by HTTP servers would remove percent encoding of qualifiers
and thus break escaping of ; used ad separation character.

Diff Detail

Repository
rDWAPPS Web applications
Branch
fix-swhid-url-quoting
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 33242
Build 52123: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 52122: arc lint + arc unit

Event Timeline

anlambert created this revision.Dec 12 2022, 5:18 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 12 2022, 5:18 PM
swh-public-ci added a comment.Dec 12 2022, 5:28 PM

Build is green

Patch application report for D8955 (id=32263)

Rebasing onto 0c4ed91a29...

Current branch diff-target is up to date.
Changes applied before test
commit 473583b6ce5be87722b3d57bf23cf1572b71a5ab
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 12 17:11:15 2022 +0100

    utils: Fix unquoted SWHID URLs generated by get_swhids_info
    
    As a SWHID with qualifiers might have some percent encoded characters (like ;
    which is used as separator between qualifiers) and HTTP servers will unquote
    received URL arguments, a SWHID must also be percent encoded when used as an
    URL argument.
    
    This prevent HTTP errors when trying to browse such SWHIDs as previously the
    unquoting performed by HTTP servers would remove percent encoding of qualifiers
    and thus break escaping of ; used ad separation character.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/52/ for more details.

Harbormaster completed remote builds in B33219: Diff 32263.Dec 12 2022, 5:28 PM
anlambert requested review of this revision.Dec 12 2022, 5:28 PM
vlorentz accepted this revision.Dec 13 2022, 12:09 PM
This revision is now accepted and ready to land.Dec 13 2022, 12:09 PM
anlambert updated this revision to Diff 32265.Dec 13 2022, 1:26 PM

Add commit also quoting SWHID URLs in iframe views;

swh-public-ci added a comment.Dec 13 2022, 1:36 PM

Build is green

Patch application report for D8955 (id=32265)

Rebasing onto 0c4ed91a29...

Current branch diff-target is up to date.
Changes applied before test
commit 62e965a34229bf96739000b1a62de52e947e04ac
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Dec 13 10:33:57 2022 +0100

    browse/iframe: Fix unquoted SWHID URLs in iframe views

commit 473583b6ce5be87722b3d57bf23cf1572b71a5ab
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 12 17:11:15 2022 +0100

    utils: Fix unquoted SWHID URLs generated by get_swhids_info
    
    As a SWHID with qualifiers might have some percent encoded characters (like ;
    which is used as separator between qualifiers) and HTTP servers will unquote
    received URL arguments, a SWHID must also be percent encoded when used as an
    URL argument.
    
    This prevent HTTP errors when trying to browse such SWHIDs as previously the
    unquoting performed by HTTP servers would remove percent encoding of qualifiers
    and thus break escaping of ; used ad separation character.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/53/ for more details.

Harbormaster completed remote builds in B33221: Diff 32265.Dec 13 2022, 1:36 PM
anlambert updated this revision to Diff 32283.Dec 15 2022, 2:14 PM

Add commit upgrading assets before tagging

swh-public-ci added a comment.Dec 15 2022, 2:23 PM

Build has FAILED

Patch application report for D8955 (id=32283)

Rebasing onto 0c4ed91a29...

Current branch diff-target is up to date.
Changes applied before test
commit 0bdc31545ed7932e2ff6100089b1053877f34d73
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Dec 15 14:12:10 2022 +0100

    package.json: Upgrade dependencies

commit 62e965a34229bf96739000b1a62de52e947e04ac
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Dec 13 10:33:57 2022 +0100

    browse/iframe: Fix unquoted SWHID URLs in iframe views

commit 473583b6ce5be87722b3d57bf23cf1572b71a5ab
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 12 17:11:15 2022 +0100

    utils: Fix unquoted SWHID URLs generated by get_swhids_info
    
    As a SWHID with qualifiers might have some percent encoded characters (like ;
    which is used as separator between qualifiers) and HTTP servers will unquote
    received URL arguments, a SWHID must also be percent encoded when used as an
    URL argument.
    
    This prevent HTTP errors when trying to browse such SWHIDs as previously the
    unquoting performed by HTTP servers would remove percent encoding of qualifiers
    and thus break escaping of ; used ad separation character.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/54/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/54/console

Harbormaster failed remote builds in B33238: Diff 32283!Dec 15 2022, 2:23 PM
anlambert updated this revision to Diff 32284.Dec 15 2022, 2:41 PM

Pin cypress to 12.0.2

swh-public-ci added a comment.Dec 15 2022, 2:49 PM

Build was aborted

Patch application report for D8955 (id=32284)

Rebasing onto 0c4ed91a29...

Current branch diff-target is up to date.
Changes applied before test
commit fa56e49a337c85ff97e38d2fd6f4dcab68401157
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Dec 15 14:12:10 2022 +0100

    package.json: Upgrade dependencies

commit 62e965a34229bf96739000b1a62de52e947e04ac
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Dec 13 10:33:57 2022 +0100

    browse/iframe: Fix unquoted SWHID URLs in iframe views

commit 473583b6ce5be87722b3d57bf23cf1572b71a5ab
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 12 17:11:15 2022 +0100

    utils: Fix unquoted SWHID URLs generated by get_swhids_info
    
    As a SWHID with qualifiers might have some percent encoded characters (like ;
    which is used as separator between qualifiers) and HTTP servers will unquote
    received URL arguments, a SWHID must also be percent encoded when used as an
    URL argument.
    
    This prevent HTTP errors when trying to browse such SWHIDs as previously the
    unquoting performed by HTTP servers would remove percent encoding of qualifiers
    and thus break escaping of ; used ad separation character.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/56/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/56/console

swh-public-ci added a comment.Dec 15 2022, 2:57 PM

Build was aborted

Patch application report for D8955 (id=32283)

Rebasing onto 0c4ed91a29...

Current branch diff-target is up to date.
Changes applied before test
commit 0bdc31545ed7932e2ff6100089b1053877f34d73
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Dec 15 14:12:10 2022 +0100

    package.json: Upgrade dependencies

commit 62e965a34229bf96739000b1a62de52e947e04ac
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Dec 13 10:33:57 2022 +0100

    browse/iframe: Fix unquoted SWHID URLs in iframe views

commit 473583b6ce5be87722b3d57bf23cf1572b71a5ab
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 12 17:11:15 2022 +0100

    utils: Fix unquoted SWHID URLs generated by get_swhids_info
    
    As a SWHID with qualifiers might have some percent encoded characters (like ;
    which is used as separator between qualifiers) and HTTP servers will unquote
    received URL arguments, a SWHID must also be percent encoded when used as an
    URL argument.
    
    This prevent HTTP errors when trying to browse such SWHIDs as previously the
    unquoting performed by HTTP servers would remove percent encoding of qualifiers
    and thus break escaping of ; used ad separation character.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/55/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/55/console

swh-public-ci added a comment.Dec 15 2022, 2:58 PM

Build was aborted

Patch application report for D8955 (id=32284)

Rebasing onto 0c4ed91a29...

Current branch diff-target is up to date.
Changes applied before test
commit fa56e49a337c85ff97e38d2fd6f4dcab68401157
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Dec 15 14:12:10 2022 +0100

    package.json: Upgrade dependencies

commit 62e965a34229bf96739000b1a62de52e947e04ac
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Dec 13 10:33:57 2022 +0100

    browse/iframe: Fix unquoted SWHID URLs in iframe views

commit 473583b6ce5be87722b3d57bf23cf1572b71a5ab
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 12 17:11:15 2022 +0100

    utils: Fix unquoted SWHID URLs generated by get_swhids_info
    
    As a SWHID with qualifiers might have some percent encoded characters (like ;
    which is used as separator between qualifiers) and HTTP servers will unquote
    received URL arguments, a SWHID must also be percent encoded when used as an
    URL argument.
    
    This prevent HTTP errors when trying to browse such SWHIDs as previously the
    unquoting performed by HTTP servers would remove percent encoding of qualifiers
    and thus break escaping of ; used ad separation character.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/57/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/57/console

Harbormaster failed remote builds in B33239: Diff 32284!Dec 15 2022, 2:58 PM
anlambert updated this revision to Diff 32285.Dec 15 2022, 2:59 PM

Remove cypress upgrade to 12.x, cy2 does not handle it well yet for parallel builds

anlambert updated this revision to Diff 32286.Dec 15 2022, 3:09 PM

Also remove cy2 upgrade

swh-public-ci added a comment.Dec 15 2022, 3:20 PM

Build has FAILED

Patch application report for D8955 (id=32285)

Rebasing onto 0c4ed91a29...

Current branch diff-target is up to date.
Changes applied before test
commit dc7a826d5957baef6569c9ea6e448cfd586f2d0a
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Dec 15 14:12:10 2022 +0100

    package.json: Upgrade dependencies

commit 62e965a34229bf96739000b1a62de52e947e04ac
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Dec 13 10:33:57 2022 +0100

    browse/iframe: Fix unquoted SWHID URLs in iframe views

commit 473583b6ce5be87722b3d57bf23cf1572b71a5ab
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 12 17:11:15 2022 +0100

    utils: Fix unquoted SWHID URLs generated by get_swhids_info
    
    As a SWHID with qualifiers might have some percent encoded characters (like ;
    which is used as separator between qualifiers) and HTTP servers will unquote
    received URL arguments, a SWHID must also be percent encoded when used as an
    URL argument.
    
    This prevent HTTP errors when trying to browse such SWHIDs as previously the
    unquoting performed by HTTP servers would remove percent encoding of qualifiers
    and thus break escaping of ; used ad separation character.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/58/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/58/console

Harbormaster failed remote builds in B33240: Diff 32285!Dec 15 2022, 3:20 PM
swh-public-ci added a comment.Dec 15 2022, 3:23 PM

Build has FAILED

Patch application report for D8955 (id=32286)

Rebasing onto 0c4ed91a29...

Current branch diff-target is up to date.
Changes applied before test
commit d6a6c484d289d52a0db7051c8dd4f74c85b9dd7c
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Dec 15 14:12:10 2022 +0100

    package.json: Upgrade dependencies

commit 62e965a34229bf96739000b1a62de52e947e04ac
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Dec 13 10:33:57 2022 +0100

    browse/iframe: Fix unquoted SWHID URLs in iframe views

commit 473583b6ce5be87722b3d57bf23cf1572b71a5ab
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 12 17:11:15 2022 +0100

    utils: Fix unquoted SWHID URLs generated by get_swhids_info
    
    As a SWHID with qualifiers might have some percent encoded characters (like ;
    which is used as separator between qualifiers) and HTTP servers will unquote
    received URL arguments, a SWHID must also be percent encoded when used as an
    URL argument.
    
    This prevent HTTP errors when trying to browse such SWHIDs as previously the
    unquoting performed by HTTP servers would remove percent encoding of qualifiers
    and thus break escaping of ; used ad separation character.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/59/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/59/console

Harbormaster failed remote builds in B33241: Diff 32286!Dec 15 2022, 3:23 PM
anlambert updated this revision to Diff 32287.Dec 15 2022, 3:30 PM

Add commit fixing a flaky cypress test

swh-public-ci added a comment.Dec 15 2022, 3:41 PM

Build is green

Patch application report for D8955 (id=32287)

Rebasing onto 0c4ed91a29...

Current branch diff-target is up to date.
Changes applied before test
commit 415867e6021ef2a9c80f655f91e39cf411541931
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Dec 15 15:29:19 2022 +0100

    cypress: Fix flaky test

commit d6a6c484d289d52a0db7051c8dd4f74c85b9dd7c
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Dec 15 14:12:10 2022 +0100

    package.json: Upgrade dependencies

commit 62e965a34229bf96739000b1a62de52e947e04ac
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Dec 13 10:33:57 2022 +0100

    browse/iframe: Fix unquoted SWHID URLs in iframe views

commit 473583b6ce5be87722b3d57bf23cf1572b71a5ab
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 12 17:11:15 2022 +0100

    utils: Fix unquoted SWHID URLs generated by get_swhids_info
    
    As a SWHID with qualifiers might have some percent encoded characters (like ;
    which is used as separator between qualifiers) and HTTP servers will unquote
    received URL arguments, a SWHID must also be percent encoded when used as an
    URL argument.
    
    This prevent HTTP errors when trying to browse such SWHIDs as previously the
    unquoting performed by HTTP servers would remove percent encoding of qualifiers
    and thus break escaping of ; used ad separation character.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/60/ for more details.

Harbormaster completed remote builds in B33242: Diff 32287.Dec 15 2022, 3:41 PM
Closed by commit rDWAPPS473583b6ce5b: utils: Fix unquoted SWHID URLs generated by get_swhids_info (authored by anlambert). · Explain WhyDec 15 2022, 3:44 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS473583b6ce5b: utils: Fix unquoted SWHID URLs generated by get_swhids_info.
anlambert added a commit: rDWAPPS62e965a34229: browse/iframe: Fix unquoted SWHID URLs in iframe views.
anlambert added a commit: rDWAPPSd6a6c484d289: package.json: Upgrade dependencies.
anlambert added a commit: rDWAPPS415867e6021e: cypress: Fix flaky test.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
cypress/
e2e/
4 lines--
1 line--
1 line--
4 lines--
1 line--
38 lines--
swh/
web/
browse/
views/
19 lines97%
Loading...
utils/
3 lines99%
Loading...
tests/
19 lines99%
Loading...
228 lines--

Diff 32287

View Options

cypress/e2e/add-forge-now-request-create.cy.js

Loading...
View Options

cypress/e2e/admin.cy.js

Loading...
View Options

cypress/e2e/home.cy.js

Loading...
View Options

cypress/e2e/language-select.cy.js

Loading...
View Options

cypress/e2e/layout.cy.js

Loading...
View Options

package.json

Loading...
View Options

swh/web/browse/views/iframe.py

Loading...
View Options

swh/web/utils/identifiers.py

Loading...
View Options

swh/web/utils/tests/test_identifiers.py

Loading...
View Options

yarn.lock

Loading...
About · Developer information · Legal