Differential D8954

docs/persistent-identifiers: Fix some broken links for browsing SWHIDs
ClosedPublic
Actions

Authored by anlambert on Dec 12 2022, 3:24 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T4721: Fix resolution of SWHID examples

Commits

rDMODf883e224e6d4: docs/persistent-identifiers: Fix some broken links for browsing SWHIDs

Summary

There were two issues that was preventing to browse some SWHIDs given as
examples in that documentation:

Some sphinx links were broken in rDMODe1c3fe80731226618616117dfd67a95f3d365645

A SWHID with ';' in its path qualifier was correctly percent escaped but when used as URL argument an extra percent escaping is required as HTTP server will unescape URL arguments and thus break SWHID percent escaping.

Regarding the second issue, I noticed the webapp do not perform the extra
percent escaping of the SWHID when generating URL to browse it, fix is
incoming.

Related to T4721

Diff Detail

Repository

rDMOD Data model

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 33216
Build 52078: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 52077: arc lint + arc unit

Event Timeline

anlambert created this revision.Dec 12 2022, 3:24 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 12 2022, 3:24 PM

Build is green

Patch application report for D8954 (id=32260)

Rebasing onto 818ad826a4...

Current branch diff-target is up to date.

Changes applied before test

commit 38fda2a7da280f3a3578c326251f337ef49b64ad
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 12 15:15:29 2022 +0100

    docs/persistent-identifiers: Fix some broken links for browsing SWHIDs
    
    There were two issues that was preventing to browse some SWHIDs given as
    examples in that documentation:
    
    - Some sphinx links were broken in rDMODe1c3fe80731226618616117dfd67a95f3d365645
    
    - A SWHID with ';' in its path qualifier was correctly percent escaped but
      when used as URL argument an extra percent escaping is required as HTTP
      server will unescape URL arguments and thus break SWHID percent escaping.
    
    Related to T4721

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/547/ for more details.

Harbormaster completed remote builds in B33216: Diff 32260.Dec 12 2022, 3:27 PM

anlambert requested review of this revision.Dec 12 2022, 3:27 PM

vlorentz accepted this revision.Dec 15 2022, 9:53 AM

This revision is now accepted and ready to land.Dec 15 2022, 9:53 AM

Update commit message

Build is green

Patch application report for D8954 (id=32275)

Rebasing onto 818ad826a4...

Current branch diff-target is up to date.

Changes applied before test

commit f883e224e6d48abd2ae07ea70287c315e9a5e5e1
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 12 15:15:29 2022 +0100

    docs/persistent-identifiers: Fix some broken links for browsing SWHIDs
    
    There were two issues that was preventing to browse some SWHIDs given as
    examples in that documentation:
    
    - Some sphinx links were broken in rDMODe1c3fe80731226618616117dfd67a95f3d365645
    
    - A SWHID with ';' in its path qualifier was correctly percent escaped but
      when used as URL argument an extra percent escaping is required as HTTP
      server will unescape URL arguments and thus break SWHID percent escaping.
    
    Closes T4721

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/548/ for more details.

Harbormaster completed remote builds in B33230: Diff 32275.Dec 15 2022, 10:45 AM

Closed by commit rDMODf883e224e6d4: docs/persistent-identifiers: Fix some broken links for browsing SWHIDs (authored by anlambert). · Explain WhyDec 15 2022, 10:47 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDMODf883e224e6d4: docs/persistent-identifiers: Fix some broken links for browsing SWHIDs.