Differential D891

Small refactoring in indexing_lister
ClosedPublic
Actions

Authored by douardda on Jan 8 2019, 10:58 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDLSdd104759ae4f: Small refactoring in indexing_lister

Summary

use a generator instead of a while loop
declare a local logger and use it instead of the root logger.

Diff Detail

Repository

rDLS Listers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jan 8 2019, 10:58 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 8 2019, 10:58 AM

Harbormaster failed remote builds in B3274: Diff 2824!Jan 8 2019, 10:59 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/41/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/41/console

douardda added a parent revision: D890: Add a 'ping' task for every lister..Jan 8 2019, 11:29 AM

douardda added a child revision: D892: Add tests for lister tasks.

vlorentz accepted this revision.Jan 8 2019, 11:52 AM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/lister/core/indexing_lister.py
174–191	You can make this a method

This revision is now accepted and ready to land.Jan 8 2019, 11:52 AM

Closed by commit rDLSdd104759ae4f: Small refactoring in indexing_lister (authored by douardda). · Explain WhyJan 10 2019, 3:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

lister/

core/

indexing_lister.py

53 lines

Diff 2899

View Options

swh/lister/core/indexing_lister.py

Small refactoring in indexing_listerClosedPublicActions