Page MenuHomeSoftware Heritage
Differential D8911

Remove ambiguous item cursors
ClosedPublic
Actions

Authored by jayeshv on Dec 1 2022, 11:34 AM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDGQLd3aee2f9eb1d: Remove ambiguous item cursors
Summary

Item cursors in origin, originsearch, visit, visitstatus and snapshotbranch
can not always be determined. This could cause client errors.
They are temporarily removed and can be added after re-factoring backend source
functions.

Diff Detail

Repository
rDGQL GraphQL API
Branch
remove-cursors-D8911
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 33232
Build 52104: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 52103: arc lint + arc unit

Event Timeline

jayeshv created this revision.Dec 1 2022, 11:34 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 1 2022, 11:34 AM
swh-public-ci added a comment.Dec 1 2022, 11:36 AM

Build is green

Patch application report for D8911 (id=32114)

Rebasing onto c28b65feaf...

Current branch diff-target is up to date.
Changes applied before test
commit 5990678ac2c4dd146ca237df727b8973a4303300
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Nov 30 16:49:55 2022 +0100

    Remove ambiguous item cursors
    
    Item cursors in origin, originsearch, visit, visitstatus and snapshotbranch
    can not always be determined. This could cause client errors.
    They are temporarily removed and can be added after re-factoring backend source
    functions.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/242/ for more details.

Harbormaster completed remote builds in B33067: Diff 32114.Dec 1 2022, 11:36 AM
jayeshv requested review of this revision.Dec 1 2022, 11:36 AM
jayeshv updated this revision to Diff 32224.Dec 8 2022, 11:10 AM

extra tests for pagination

swh-public-ci added a comment.Dec 8 2022, 11:13 AM

Build is green

Patch application report for D8911 (id=32224)

Rebasing onto c28b65feaf...

Current branch diff-target is up to date.
Changes applied before test
commit dd73f7d41a30f774567a9381d2b21236fb255c2f
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Nov 30 16:49:55 2022 +0100

    Remove ambiguous item cursors
    
    Item cursors in origin, originsearch, visit, visitstatus and snapshotbranch
    can not always be determined. This could cause client errors.
    They are temporarily removed and can be added after re-factoring backend source
    functions.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/245/ for more details.

Harbormaster completed remote builds in B33179: Diff 32224.Dec 8 2022, 11:13 AM
jayeshv updated this revision to Diff 32235.Dec 8 2022, 5:16 PM

improve tests

swh-public-ci added a comment.Dec 8 2022, 5:19 PM

Build is green

Patch application report for D8911 (id=32235)

Rebasing onto c28b65feaf...

Current branch diff-target is up to date.
Changes applied before test
commit 86a48e6663a776aec15129959d2be7a7d337d040
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Nov 30 16:49:55 2022 +0100

    Remove ambiguous item cursors
    
    Item cursors in origin, originsearch, visit, visitstatus and snapshotbranch
    can not always be determined. This could cause client errors.
    They are temporarily removed and can be added after re-factoring backend source
    functions.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/246/ for more details.

Harbormaster completed remote builds in B33190: Diff 32235.Dec 8 2022, 5:19 PM
jayeshv retitled this revision from [WIP] Remove ambiguous item cursors to Remove ambiguous item cursors.Dec 12 2022, 3:29 PM
vlorentz added a subscriber: vlorentz.Dec 15 2022, 10:08 AM

Please add comments next to commented out code to explain why it's commented out. (it could be a link to this diff)

jayeshv updated this revision to Diff 32277.Dec 15 2022, 11:11 AM

add extra comments, rebase

jayeshv retitled this revision from Remove ambiguous item cursors to [WP]: Remove ambiguous item cursors.Dec 15 2022, 11:12 AM
swh-public-ci added a comment.Dec 15 2022, 11:13 AM

Build is green

Patch application report for D8911 (id=32277)

Rebasing onto c664ef42e7...

Current branch diff-target is up to date.
Changes applied before test
commit 19bb17892866cdab9b18a39382aedc8099a88293
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Nov 30 16:49:55 2022 +0100

    Remove ambiguous item cursors
    
    Item cursors in origin, originsearch, visit, visitstatus and snapshotbranch
    can not always be determined. This could cause client errors.
    They are temporarily removed from the schema and can be added after
    re-factoring backend source functions.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/251/ for more details.

Harbormaster completed remote builds in B33232: Diff 32277.Dec 15 2022, 11:13 AM
jayeshv updated this revision to Diff 32278.Dec 15 2022, 11:15 AM

remvove unnecessary comment

jayeshv updated this revision to Diff 32279.Dec 15 2022, 11:16 AM

remove unused code

swh-public-ci added a comment.Dec 15 2022, 11:18 AM

Build is green

Patch application report for D8911 (id=32278)

Rebasing onto c664ef42e7...

Current branch diff-target is up to date.
Changes applied before test
commit 611b02b936c64f0b668b16ad7110dab56ae88b9f
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Nov 30 16:49:55 2022 +0100

    Remove ambiguous item cursors
    
    Item cursors in origin, originsearch, visit, visitstatus and snapshotbranch
    can not always be determined. This could cause client errors.
    They are temporarily removed from the schema and can be added after
    re-factoring backend source functions.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/252/ for more details.

Harbormaster completed remote builds in B33233: Diff 32278.Dec 15 2022, 11:18 AM
swh-public-ci added a comment.Dec 15 2022, 11:19 AM

Build is green

Patch application report for D8911 (id=32279)

Rebasing onto c664ef42e7...

Current branch diff-target is up to date.
Changes applied before test
commit d3aee2f9eb1d3617e5bc62a9b39a17b03393f399
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Nov 30 16:49:55 2022 +0100

    Remove ambiguous item cursors
    
    Item cursors in origin, originsearch, visit, visitstatus and snapshotbranch
    can not always be determined. This could cause client errors.
    They are temporarily removed from the schema and can be added after
    re-factoring backend source functions.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/253/ for more details.

Harbormaster completed remote builds in B33234: Diff 32279.Dec 15 2022, 11:19 AM
jayeshv retitled this revision from [WP]: Remove ambiguous item cursors to Remove ambiguous item cursors.Dec 15 2022, 12:03 PM
vlorentz accepted this revision.Dec 15 2022, 12:07 PM

thx

This revision is now accepted and ready to land.Dec 15 2022, 12:07 PM
Closed by commit rDGQLd3aee2f9eb1d: Remove ambiguous item cursors (authored by jayeshv). · Explain WhyDec 15 2022, 12:09 PM
This revision was automatically updated to reflect the committed changes.
jayeshv added a commit: rDGQLd3aee2f9eb1d: Remove ambiguous item cursors.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
graphql/
resolvers/
4 lines100%
Loading...
schema/
55 lines--
tests/
functional/
4 lines100%
Loading...
84 lines100%
Loading...
3 lines100%
Loading...

Diff 32277

View Options

swh/graphql/resolvers/visit.py

Loading...
View Options

swh/graphql/schema/schema.graphql

Loading...
View Options

swh/graphql/tests/functional/test_branch_connection.py

Loading...
View Options

swh/graphql/tests/functional/test_pagination.py

Loading...
View Options

swh/graphql/tests/functional/test_visit_status.py

Loading...
About · Developer information · Legal