Differential D8904

metadata_dictionary: Fix 'Invalid IPv6 URL' crash
ClosedPublic
Actions

Authored by vlorentz on Nov 30 2022, 9:45 AM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Maniphest Tasks

T4709: npm mapping: ValueError: Invalid IPv6 URL

Commits

rDCIDXb2d8afff6fa5: metadata_dictionary: Fix 'Invalid IPv6 URL' crash

Summary

Resolves T4709.

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 33044
Build 51790: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 51789: arc lint + arc unit

Event Timeline

vlorentz created this revision.Nov 30 2022, 9:45 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 30 2022, 9:45 AM

Build is green

Patch application report for D8904 (id=32092)

Rebasing onto f44e14b11f...

Current branch diff-target is up to date.

Changes applied before test

commit b2d8afff6fa502173b31431b7129ad89d24b7048
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 30 09:44:21 2022 +0100

    metadata_dictionary: Fix 'Invalid IPv6 URL' crash

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/533/ for more details.

Harbormaster completed remote builds in B33044: Diff 32092.Nov 30 2022, 9:49 AM

vlorentz requested review of this revision.Nov 30 2022, 9:49 AM

...

This revision is now accepted and ready to land.Nov 30 2022, 10:39 AM

Closed by commit rDCIDXb2d8afff6fa5: metadata_dictionary: Fix 'Invalid IPv6 URL' crash (authored by vlorentz). · Explain WhyNov 30 2022, 11:46 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCIDXb2d8afff6fa5: metadata_dictionary: Fix 'Invalid IPv6 URL' crash.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

indexer/

metadata_dictionary/

utils.py

6 lines

100%

tests/

metadata_dictionary/

test_npm.py

11 lines

100%

Diff 32092

View Options

swh/indexer/metadata_dictionary/utils.py