Drop content_language and content_ctags tables and related SQL functions
ClosedPublic
Actions

Authored by vlorentz on Nov 28 2022, 12:33 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDCIDXa5ee54aedece: Drop content_language and content_ctags tables and related SQL functions

Summary

As noted by @ardumont in D8873#inline-62903

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 28 2022, 12:33 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 28 2022, 12:33 PM

vlorentz mentioned this in D8873: storage: Insert from temporary tables in consistent order.Nov 28 2022, 12:34 PM

Build has FAILED

Patch application report for D8888 (id=32040)

Rebasing onto f7833b7e2d...

Current branch diff-target is up to date.

Changes applied before test

commit 07b34be4f605ba3106aea1d535623b1d573f7655
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Nov 28 12:33:29 2022 +0100

    Drop content_language and content_ctags tables and related SQL functions

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/529/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/529/console

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 28 2022, 12:38 PM

Harbormaster failed remote builds in B32989: Diff 32040!

remove index content_language_pkey

Build is green

Patch application report for D8888 (id=32043)

Rebasing onto f7833b7e2d...

Current branch diff-target is up to date.

Changes applied before test

commit a5ee54aedece0cac8398e64fe2d2355cd482df13
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Nov 28 12:33:29 2022 +0100

    Drop content_language and content_ctags tables and related SQL functions

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/530/ for more details.

Harbormaster completed remote builds in B32992: Diff 32043.Nov 28 2022, 3:42 PM

vlorentz requested review of this revision.Nov 28 2022, 3:42 PM

lgtm

one question to team inline.

swh/indexer/sql/upgrades/137.sql
18	@olasd @zack shall we drop those tables once and for all (and no longer look back)?

This revision is now accepted and ready to land.Nov 29 2022, 2:15 PM

olasd added inline comments.Nov 29 2022, 3:28 PM

swh/indexer/sql/upgrades/137.sql
18	The `content_ctags` table is empty in prod. The `content_language` table is, er, full of creative data that doesn't really have any relationship to reality. I think they're best gone.

Closed by commit rDCIDXa5ee54aedece: Drop content_language and content_ctags tables and related SQL functions (authored by vlorentz). · Explain WhyNov 29 2022, 3:28 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCIDXa5ee54aedece: Drop content_language and content_ctags tables and related SQL functions.

ardumont added inline comments.Nov 29 2022, 3:38 PM

swh/indexer/sql/upgrades/137.sql
18	Fine then! I should have checked their data indeed prior to me pinging you. Memory served me badly this time, i remembered it was just not empty...