Page MenuHomeSoftware Heritage

replay: Do not ignore externals in copyfrom operations
ClosedPublic

Authored by anlambert on Nov 24 2022, 11:56 AM.

Details

Summary

When copying a directory from an ancestor revision, do not ignore
externals as properties are also copied by subversion so external
paths must also be exported.

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Branch
copyfrom-do-not-ignore-externals
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 33172
Build 52002: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 52001: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D8882 (id=32015)

Rebasing onto bcd1e753c6...

Current branch diff-target is up to date.
Changes applied before test
commit 2730021d2f4b6c516eae8f5f75e484757b48acf0
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Nov 24 11:54:03 2022 +0100

    replay: Do not ignore externals in copyfrom operations
    
    When copying a directory from an ancestor revision, do not ignore
    externals as properties are also copied by subversion so external
    paths must also be exported.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/357/ for more details.

ardumont added inline comments.
swh/loader/svn/tests/test_externals.py
1697

what happened in this test initially (without the runtime code change)?

Build is green

Patch application report for D8882 (id=32217)

Rebasing onto 2b80484b8b...

Current branch diff-target is up to date.
Changes applied before test
commit 9f3a5800d208f060949b8fb0f3e9788ab275a384
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Nov 24 11:54:03 2022 +0100

    replay: Do not ignore externals in copyfrom operations
    
    When copying a directory from an ancestor revision, do not ignore
    externals as properties are also copied by subversion so external
    paths must also be exported.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/361/ for more details.

swh/loader/svn/tests/test_externals.py
1697

trunk/externals/hello directory was not exported while it must be

This revision is now accepted and ready to land.Dec 8 2022, 11:38 AM