Page MenuHomeSoftware Heritage
Differential D8875

cypress/origin-save: Fix flaky test
ClosedPublic
Actions

Authored by anlambert on Nov 23 2022, 11:53 AM.

Details

Reviewers
None
Group Reviewers
Reviewers
Commits
rDWAPPScd820470fa59: cypress/origin-save: Fix flaky test
Summary

Some wait instructions were missing to ensure UI update before asserting.

Diff Detail

Repository
rDWAPPS Web applications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 32937
Build 51622: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 51621: arc lint + arc unit

Event Timeline

anlambert created this revision.Nov 23 2022, 11:53 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 23 2022, 11:53 AM
swh-public-ci added a comment.Nov 23 2022, 12:04 PM

Build has FAILED

Patch application report for D8875 (id=31998)

Rebasing onto b04d5848c6...

Current branch diff-target is up to date.
Changes applied before test
commit 526fddf835e2f6282e1321b0c4dbdddffd8d7a36
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 23 11:51:39 2022 +0100

    package.json: Bump cypress to 11.2.0

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2192/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2192/console

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 23 2022, 12:04 PM
Harbormaster failed remote builds in B32929: Diff 31998!
swh-public-ci added a comment.Nov 23 2022, 12:25 PM

Build has FAILED

Patch application report for D8875 (id=31998)

Rebasing onto b04d5848c6...

Current branch diff-target is up to date.
Changes applied before test
commit 526fddf835e2f6282e1321b0c4dbdddffd8d7a36
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 23 11:51:39 2022 +0100

    package.json: Bump cypress to 11.2.0

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2193/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2193/console

anlambert updated this revision to Diff 32002.Nov 23 2022, 2:19 PM

Only bump cypress as new axios release is buggy.

swh-public-ci added a comment.Nov 23 2022, 2:32 PM

Build is green

Patch application report for D8875 (id=32002)

Rebasing onto b04d5848c6...

Current branch diff-target is up to date.
Changes applied before test
commit e369bfe815828fdaa3aa85b743208014e1354ea8
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 23 14:19:11 2022 +0100

    package.json: Bump cypress to 11.2.0

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2194/ for more details.

Harbormaster completed remote builds in B32935: Diff 32002.Nov 23 2022, 2:32 PM
anlambert requested review of this revision.Nov 23 2022, 2:32 PM
anlambert updated this revision to Diff 32004.Nov 23 2022, 2:45 PM

Update commit message

swh-public-ci added a comment.Nov 23 2022, 2:56 PM

Build has FAILED

Patch application report for D8875 (id=32004)

Rebasing onto b04d5848c6...

Current branch diff-target is up to date.
Changes applied before test
commit 408b3f179b2aaab1eb67024d5979f542c7e2642b
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 23 14:19:11 2022 +0100

    package.json: Bump cypress to 11.2.0
    
    Hang issue on Jenkins has been fixed in this release so we can
    finally bump cypress to 11.x.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2195/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2195/console

Harbormaster failed remote builds in B32937: Diff 32004!Nov 23 2022, 2:56 PM
anlambert updated this revision to Diff 32005.Nov 23 2022, 3:09 PM

Add commit fixing a flaky cypress test

swh-public-ci added a comment.Nov 23 2022, 3:29 PM

Build was aborted

Patch application report for D8875 (id=32005)

Rebasing onto b04d5848c6...

Current branch diff-target is up to date.
Changes applied before test
commit 6b4db0552e806c628a1c5153250f61e59ce39eee
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 23 15:08:34 2022 +0100

    cypress/origin-save: Fix flaky test

commit 408b3f179b2aaab1eb67024d5979f542c7e2642b
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 23 14:19:11 2022 +0100

    package.json: Bump cypress to 11.2.0
    
    Hang issue on Jenkins has been fixed in this release so we can
    finally bump cypress to 11.x.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2196/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2196/console

Harbormaster failed remote builds in B32938: Diff 32005!Nov 23 2022, 3:29 PM
swh-public-ci added a comment.Nov 23 2022, 3:36 PM

Build was aborted

Patch application report for D8875 (id=32005)

Rebasing onto b04d5848c6...

Current branch diff-target is up to date.
Changes applied before test
commit 6b4db0552e806c628a1c5153250f61e59ce39eee
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 23 15:08:34 2022 +0100

    cypress/origin-save: Fix flaky test

commit 408b3f179b2aaab1eb67024d5979f542c7e2642b
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 23 14:19:11 2022 +0100

    package.json: Bump cypress to 11.2.0
    
    Hang issue on Jenkins has been fixed in this release so we can
    finally bump cypress to 11.x.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2197/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2197/console

swh-public-ci added a comment.Nov 23 2022, 3:49 PM

Build was aborted

Patch application report for D8875 (id=32005)

Rebasing onto b04d5848c6...

Current branch diff-target is up to date.
Changes applied before test
commit 6b4db0552e806c628a1c5153250f61e59ce39eee
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 23 15:08:34 2022 +0100

    cypress/origin-save: Fix flaky test

commit 408b3f179b2aaab1eb67024d5979f542c7e2642b
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 23 14:19:11 2022 +0100

    package.json: Bump cypress to 11.2.0
    
    Hang issue on Jenkins has been fixed in this release so we can
    finally bump cypress to 11.x.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2198/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2198/console

swh-public-ci added a comment.Nov 23 2022, 4:11 PM

Build was aborted

Patch application report for D8875 (id=32005)

Rebasing onto b04d5848c6...

Current branch diff-target is up to date.
Changes applied before test
commit 6b4db0552e806c628a1c5153250f61e59ce39eee
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 23 15:08:34 2022 +0100

    cypress/origin-save: Fix flaky test

commit 408b3f179b2aaab1eb67024d5979f542c7e2642b
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 23 14:19:11 2022 +0100

    package.json: Bump cypress to 11.2.0
    
    Hang issue on Jenkins has been fixed in this release so we can
    finally bump cypress to 11.x.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2199/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2199/console

anlambert updated this revision to Diff 32006.Nov 23 2022, 4:14 PM

Trigger new build

anlambert updated this revision to Diff 32007.Nov 23 2022, 4:24 PM

Remove cypress upgrade, the hanging bug appeared again after a couple of job executions (sigh)

swh-public-ci added a comment.Nov 23 2022, 4:24 PM

Build was aborted

Patch application report for D8875 (id=32006)

Rebasing onto b04d5848c6...

Current branch diff-target is up to date.
Changes applied before test
commit 275bb380435c6e0de1cf2e4b9969eb15d16a7925
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 23 14:19:11 2022 +0100

    package.json: Bump cypress to 11.2.0
    
    Hang issue on Jenkins has been fixed in this release so we can
    finally bump cypress to 11.x.

commit cd820470fa59192f318afc081d00e80c25fe2cc6
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 23 15:08:34 2022 +0100

    cypress/origin-save: Fix flaky test

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1/console

Harbormaster failed remote builds in B32939: Diff 32006!Nov 23 2022, 4:24 PM
swh-public-ci added a comment.Nov 23 2022, 4:35 PM

Build is green

Patch application report for D8875 (id=32007)

Rebasing onto b04d5848c6...

Current branch diff-target is up to date.
Changes applied before test
commit cd820470fa59192f318afc081d00e80c25fe2cc6
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 23 15:08:34 2022 +0100

    cypress/origin-save: Fix flaky test

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2/ for more details.

Harbormaster completed remote builds in B32940: Diff 32007.Nov 23 2022, 4:35 PM
anlambert retitled this revision from package.json: Bump cypress to 11.2.0 to cypress/origin-save: Fix flaky test.Nov 23 2022, 4:37 PM
anlambert edited the summary of this revision. (Show Details)
swh-public-ci added a comment.Nov 23 2022, 4:47 PM

Build is green

Patch application report for D8875 (id=32007)

Rebasing onto b04d5848c6...

Current branch diff-target is up to date.
Changes applied before test
commit cd820470fa59192f318afc081d00e80c25fe2cc6
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 23 15:08:34 2022 +0100

    cypress/origin-save: Fix flaky test

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/3/ for more details.

anlambert added a child revision: D8878: vault/assets: Fix cooking task creation when there is a pending one.Nov 23 2022, 4:50 PM
swh-public-ci added a comment.Nov 23 2022, 5:21 PM

Build was aborted

Patch application report for D8875 (id=32007)

Rebasing onto b04d5848c6...

Current branch diff-target is up to date.
Changes applied before test
commit cd820470fa59192f318afc081d00e80c25fe2cc6
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 23 15:08:34 2022 +0100

    cypress/origin-save: Fix flaky test

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/4/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/4/console

Harbormaster failed remote builds in B32940: Diff 32007!Nov 23 2022, 5:21 PM
swh-public-ci added a comment.Nov 23 2022, 5:41 PM

Build is green

Patch application report for D8875 (id=32007)

Rebasing onto b04d5848c6...

Current branch diff-target is up to date.
Changes applied before test
commit cd820470fa59192f318afc081d00e80c25fe2cc6
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 23 15:08:34 2022 +0100

    cypress/origin-save: Fix flaky test

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/6/ for more details.

Harbormaster completed remote builds in B32940: Diff 32007.Nov 23 2022, 5:41 PM
swh-public-ci added a comment.Nov 24 2022, 12:05 PM

Build is green

Patch application report for D8875 (id=32007)

Rebasing onto b04d5848c6...

Current branch diff-target is up to date.
Changes applied before test
commit cd820470fa59192f318afc081d00e80c25fe2cc6
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 23 15:08:34 2022 +0100

    cypress/origin-save: Fix flaky test

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/8/ for more details.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 24 2022, 2:29 PM
Closed by commit rDWAPPScd820470fa59: cypress/origin-save: Fix flaky test (authored by anlambert). · Explain Why
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPScd820470fa59: cypress/origin-save: Fix flaky test.

Revision Contents
Changeset List

PathSize
2 lines
8 lines

Diff 32004

View Options

package.json

Loading...
View Options

yarn.lock

Loading...
About · Developer information · Legal