Page MenuHomeSoftware Heritage
Differential D8856

deployment/upgrade-swh-services: Update with elastic deployment part
ClosedPublic
Actions

Authored by ardumont on Nov 18 2022, 11:51 AM.

Details

Reviewers
lunar
olasd
Group Reviewers
System administrators
Commits
rDDOC999e6d68d9d7: Upgrade services: Add elastic deployment chapter
rDDOCd8b2c7c1e504: Upgrade services: Rewrote part to prepare the elastic deployment part
Summary

This explicits the main ways to deploy currently:

  • through debian packages and systemd services (main deployment)
  • dynamic through kubernetes (on-going transition target)
Test Plan

make -C sysadm html happy

Diff Detail

Repository
rDDOC Development documentation
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Nov 18 2022, 11:51 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 18 2022, 11:51 AM
swh-public-ci added a comment.Nov 18 2022, 11:54 AM

Build has FAILED

Patch application report for D8856 (id=31923)

Rebasing onto e50484b0b7...

Current branch diff-target is up to date.
Changes applied before test
commit 36638d1699dbb69f79ee7f45c3a712ea4c3e98db
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Nov 18 11:24:57 2022 +0100

    deployment/upgrade-swh-services: Update with elastic deployment part

Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/267/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/267/console

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 18 2022, 11:54 AM
Harbormaster failed remote builds in B32851: Diff 31923!
ardumont updated this revision to Diff 31928.Nov 18 2022, 3:20 PM

Update

swh-public-ci added a comment.Nov 18 2022, 3:22 PM

Build has FAILED

Patch application report for D8856 (id=31928)

Rebasing onto e50484b0b7...

Current branch diff-target is up to date.
Changes applied before test
commit 1e9c5ee752786e8ec4018f75af1876ec739a27b4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Nov 18 11:24:57 2022 +0100

    deployment/upgrade-swh-services: Update with elastic deployment part

Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/268/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/268/console

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 18 2022, 3:22 PM
Harbormaster failed remote builds in B32856: Diff 31928!
ardumont updated this revision to Diff 31929.Nov 18 2022, 6:23 PM
  • Upgrade services: Rewrote part to prepare the elastic deployment part
  • Upgrade services: Add the elastic deployment part
swh-public-ci added a comment.Nov 18 2022, 6:30 PM

Build is green

Patch application report for D8856 (id=31929)

Rebasing onto e50484b0b7...

Current branch diff-target is up to date.
Changes applied before test
commit 0f10127968665484daa982d4cf058224983834e8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Nov 18 18:22:13 2022 +0100

    Upgrade services: Add the elastic deployment part

commit d8b2c7c1e5046258884d1f0d5869e24a30bf5e78
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Nov 18 11:24:57 2022 +0100

    Upgrade services: Rewrote part to prepare the elastic deployment part

See https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/269/ for more details.

Harbormaster completed remote builds in B32857: Diff 31929.Nov 18 2022, 6:30 PM
ardumont requested review of this revision.Nov 18 2022, 6:30 PM
ardumont retitled this revision from [wip] deployment/upgrade-swh-services: Update with elastic deployment part to deployment/upgrade-swh-services: Update with elastic deployment part.Nov 18 2022, 6:32 PM
ardumont edited the summary of this revision. (Show Details)
lunar added a subscriber: lunar.Nov 21 2022, 12:15 PM

Review the first part.

sysadm/deployment/upgrade-swh-service.rst
47–49

I don’t understand the first sentence. Are some words missing or maybe a mistranslation from French? (Happy to help.)

71

in charge of something

72

harmony

129

Extra parenthesis.

ardumont updated this revision to Diff 31938.Nov 21 2022, 1:51 PM
ardumont marked 2 inline comments as done.

Adapt according to first round of review

sysadm/deployment/upgrade-swh-service.rst
47–49

typo in the first sentence "an evolution or fix an issue".
It's not that bad. I've tried to reword it a bit nonetheless.
Hopefully it's clearer.

71

yes, i missed it.

swh-public-ci added a comment.Nov 21 2022, 1:53 PM

Build has FAILED

Patch application report for D8856 (id=31938)

Rebasing onto e50484b0b7...

Current branch diff-target is up to date.
Changes applied before test
commit 0513d2cb7e105e6cca60c2399e7327584f3564c1
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Nov 18 18:22:13 2022 +0100

    Upgrade services: Add elastic deployment chapter

commit d8b2c7c1e5046258884d1f0d5869e24a30bf5e78
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Nov 18 11:24:57 2022 +0100

    Upgrade services: Rewrote part to prepare the elastic deployment part

Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/270/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/270/console

Harbormaster failed remote builds in B32866: Diff 31938!Nov 21 2022, 1:54 PM
ardumont updated this revision to Diff 31944.Nov 21 2022, 2:41 PM

Fix build

swh-public-ci added a comment.Nov 21 2022, 2:48 PM

Build is green

Patch application report for D8856 (id=31944)

Rebasing onto e50484b0b7...

Current branch diff-target is up to date.
Changes applied before test
commit 999e6d68d9d731556d569dd73a85888d602afa2c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Nov 18 18:22:13 2022 +0100

    Upgrade services: Add elastic deployment chapter

commit d8b2c7c1e5046258884d1f0d5869e24a30bf5e78
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Nov 18 11:24:57 2022 +0100

    Upgrade services: Rewrote part to prepare the elastic deployment part

See https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/271/ for more details.

Harbormaster completed remote builds in B32872: Diff 31944.Nov 21 2022, 2:48 PM
ardumont marked 2 inline comments as done.Nov 21 2022, 2:49 PM
ardumont edited the summary of this revision. (Show Details)
lunar added a comment.Nov 21 2022, 6:06 PM

The second part looks good to me. :)

ardumont added a comment.Nov 21 2022, 6:08 PM

The second part looks good to me. :)

\o/ cool, thx for the review.

(I've adapted the first bit you mentioned).

lunar accepted this revision.Nov 21 2022, 6:17 PM
lunar edited reviewers, added: System administrators; removed: Reviewers.

lgtm

olasd accepted this revision.Nov 21 2022, 6:18 PM
olasd added a subscriber: olasd.

LGTM too, thanks!

sysadm/deployment/upgrade-swh-service.rst
248–268

I guess if we're going that way (I just use a virtualenv on my host machine, fwiw) we'll (eventually) want to have a Dockerfile to run this script rather than poke at a container manually.

That'll happen when we figure out automation for this process.

This revision is now accepted and ready to land.Nov 21 2022, 6:18 PM
ardumont added inline comments.Nov 21 2022, 6:22 PM
sysadm/deployment/upgrade-swh-service.rst
248–268

yes!

Closed by commit rDDOCd8b2c7c1e504: Upgrade services: Rewrote part to prepare the elastic deployment part (authored by ardumont). · Explain WhyNov 22 2022, 9:33 AM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDDOCd8b2c7c1e504: Upgrade services: Rewrote part to prepare the elastic deployment part.
ardumont added a commit: rDDOC999e6d68d9d7: Upgrade services: Add elastic deployment chapter.
ardumont added inline comments.Nov 22 2022, 4:52 PM
sysadm/deployment/upgrade-swh-service.rst
248–268

heads up:

  • Adaptation to make that step automatized [1]
  • And then once ^ landed, the documentation updating that part [2]

[1] https://gitlab.softwareheritage.org/infra/swh-apps/-/merge_requests/10

[2] D8871

Revision Contents
Changeset List

PathSize
sysadm/
deployment/
158 lines

Diff 31961

View Options

sysadm/deployment/upgrade-swh-service.rst

Loading...
About · Developer information · Legal