Page MenuHomeSoftware Heritage

test_converters: Rename 'raw_manifest' to 'raw_string'
ClosedPublic

Authored by vlorentz on Oct 25 2022, 6:06 PM.

Details

Summary

To avoid any confusion, as raw_manifest contains the git header

Diff Detail

Repository
rDLDG Git loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8775 (id=31633)

Rebasing onto 7324b60ed1...

Current branch diff-target is up to date.
Changes applied before test
commit 4e501c7ba4ac74b0e4383869205e3474260311f2
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 25 18:06:03 2022 +0200

    test_converters: Rename 'raw_manifest' to 'raw_string'
    
    To avoid any confusion, as raw_manifest contains the git header

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/230/ for more details.

olasd added a subscriber: olasd.

must... resist... painting the bikeshed (git_manifest? git_object? raw_object?)

This revision is now accepted and ready to land.Oct 25 2022, 6:15 PM

Dulwich calls it "raw_string", so I went with that

Dulwich calls it "raw_string", so I went with that

Good call !