Differential D8755

Reset Sentry tags when leaving an object's context
ClosedPublic
Actions

Authored by vlorentz on Oct 24 2022, 10:35 AM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDCIDXdc48e9ebaae6: Reset Sentry tags when leaving an object's context

Summary

Without this, some Sentry issues were tagged with the wrong object,
which can be very confusing

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 32518
Build 50928: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 50927: arc lint + arc unit

Event Timeline

vlorentz created this revision.Oct 24 2022, 10:35 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 24 2022, 10:35 AM

Build is green

Patch application report for D8755 (id=31564)

Rebasing onto e6895ba5cf...

Current branch diff-target is up to date.

Changes applied before test

commit dc48e9ebaae60037fe496edd105ccd0829b87856
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Oct 24 10:34:55 2022 +0200

    Reset Sentry tags when leaving an object's context
    
    Without this, some Sentry issues were tagged with the wrong object,
    which can be very confusing

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/515/ for more details.

Harbormaster completed remote builds in B32518: Diff 31564.Oct 24 2022, 10:42 AM

vlorentz requested review of this revision.Oct 24 2022, 10:42 AM

anlambert accepted this revision.Oct 24 2022, 4:59 PM

This revision is now accepted and ready to land.Oct 24 2022, 4:59 PM

Closed by commit rDCIDXdc48e9ebaae6: Reset Sentry tags when leaving an object's context (authored by vlorentz). · Explain WhyOct 24 2022, 6:25 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCIDXdc48e9ebaae6: Reset Sentry tags when leaving an object's context.