Page MenuHomeSoftware Heritage

tests: Simplify svn loading tasks creation tests implementation
ClosedPublic

Authored by anlambert on Oct 18 2022, 1:24 PM.

Details

Summary

Use helper fixture loading_task_creation_for_listed_origin_test from
swh-loader-core and remove redundant tests.

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Branch
test-tasks-simplify
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 32357
Build 50680: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 50679: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D8699 (id=31412)

Rebasing onto aaa82617be...

Current branch diff-target is up to date.
Changes applied before test
commit c6c00e2796220edf147698f1f1bcf92754deeec2
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 18 13:24:21 2022 +0200

    tests: Simplify svn loading tasks creation tests implementation
    
    Use helper fixture loading_task_creation_for_listed_origin_test from
    swh-loader-core and remove redundant tests.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/337/ for more details.

Parametrize tests with extra loader arguments

Build is green

Patch application report for D8699 (id=31415)

Rebasing onto aaa82617be...

Current branch diff-target is up to date.
Changes applied before test
commit 5d3433e9cee155a72238dbd0748b65c2172973a8
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 18 13:24:21 2022 +0200

    tests: Simplify svn loading tasks creation tests implementation
    
    Use helper fixture loading_task_creation_for_listed_origin_test from
    swh-loader-core and remove redundant tests.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/338/ for more details.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 18 2022, 3:45 PM
This revision was automatically updated to reflect the committed changes.