Page MenuHomeSoftware Heritage
Differential D8695

Move all non pytest-related functions from conftest to utils.py
ClosedPublic
Actions

Authored by douardda on Oct 18 2022, 10:56 AM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDPROV4ed652e03d12: Move all non pytest-related functions from conftest to utils.py
rDPROVb686e9a516e0: tests: small fixes in test_journal_client.py
Summary

and rename test_utils.py as utils.py to prevent confusion about this
module not being a set of tests.

Diff Detail

Event Timeline

douardda created this revision.Oct 18 2022, 10:56 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 18 2022, 10:56 AM
douardda added a child revision: D8696: tests: simplify and (possibly) fix the grpc_server helper context manager.Oct 18 2022, 10:56 AM
swh-public-ci added a comment.Oct 18 2022, 11:03 AM

Build is green

Patch application report for D8695 (id=31402)

Rebasing onto 022b6f7661...

Current branch diff-target is up to date.
Changes applied before test
commit a3f7850711b61a596fc3b820ef929a235a5871af
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Oct 18 10:15:14 2022 +0200

    Move all non pytest-related functions from conftest to utils.py
    
    and rename test_utils.py as utils.py to prevent confusion about this
    module not being a set of tests.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/700/ for more details.

Harbormaster completed remote builds in B32350: Diff 31402.Oct 18 2022, 11:03 AM
douardda requested review of this revision.Oct 18 2022, 11:03 AM
vlorentz accepted this revision.Oct 18 2022, 11:04 AM
This revision is now accepted and ready to land.Oct 18 2022, 11:04 AM
douardda updated this revision to Diff 31503.Oct 18 2022, 8:18 PM

rebase (+ a small fix)

swh-public-ci added a comment.Oct 18 2022, 8:33 PM

Build has FAILED

Patch application report for D8695 (id=31503)

Rebasing onto 60c5a5c463...

Current branch diff-target is up to date.
Changes applied before test
commit 4ed652e03d1277139bd4ec5c9a34b3dc76baf6e8
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Oct 18 10:15:14 2022 +0200

    Move all non pytest-related functions from conftest to utils.py
    
    and rename test_utils.py as utils.py to prevent confusion about this
    module not being a set of tests.

commit b686e9a516e08add6efdc1c87e74246004036137
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Oct 18 20:14:47 2022 +0200

    tests: small fixes in test_journal_client.py

Link to build: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/704/
See console output for more information: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/704/console

Harbormaster failed remote builds in B32449: Diff 31503!Oct 18 2022, 8:33 PM
swh-public-ci added a comment.Oct 18 2022, 8:59 PM

Build has FAILED

Patch application report for D8695 (id=31503)

Rebasing onto 60c5a5c463...

Current branch diff-target is up to date.
Changes applied before test
commit 4ed652e03d1277139bd4ec5c9a34b3dc76baf6e8
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Oct 18 10:15:14 2022 +0200

    Move all non pytest-related functions from conftest to utils.py
    
    and rename test_utils.py as utils.py to prevent confusion about this
    module not being a set of tests.

commit b686e9a516e08add6efdc1c87e74246004036137
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Oct 18 20:14:47 2022 +0200

    tests: small fixes in test_journal_client.py

Link to build: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/706/
See console output for more information: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/706/console

swh-public-ci added a comment.Oct 19 2022, 10:08 AM

Build was aborted

Patch application report for D8695 (id=31503)

Rebasing onto 60c5a5c463...

Current branch diff-target is up to date.
Changes applied before test
commit 4ed652e03d1277139bd4ec5c9a34b3dc76baf6e8
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Oct 18 10:15:14 2022 +0200

    Move all non pytest-related functions from conftest to utils.py
    
    and rename test_utils.py as utils.py to prevent confusion about this
    module not being a set of tests.

commit b686e9a516e08add6efdc1c87e74246004036137
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Oct 18 20:14:47 2022 +0200

    tests: small fixes in test_journal_client.py

Link to build: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/707/
See console output for more information: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/707/console

swh-public-ci added a comment.Oct 19 2022, 10:26 AM

Build is green

Patch application report for D8695 (id=31503)

Rebasing onto 60c5a5c463...

Current branch diff-target is up to date.
Changes applied before test
commit 4ed652e03d1277139bd4ec5c9a34b3dc76baf6e8
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Oct 18 10:15:14 2022 +0200

    Move all non pytest-related functions from conftest to utils.py
    
    and rename test_utils.py as utils.py to prevent confusion about this
    module not being a set of tests.

commit b686e9a516e08add6efdc1c87e74246004036137
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Oct 18 20:14:47 2022 +0200

    tests: small fixes in test_journal_client.py

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/708/ for more details.

Harbormaster completed remote builds in B32449: Diff 31503.Oct 19 2022, 10:26 AM
Closed by commit rDPROVb686e9a516e0: tests: small fixes in test_journal_client.py (authored by douardda). · Explain WhyOct 19 2022, 10:33 AM
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDPROVb686e9a516e0: tests: small fixes in test_journal_client.py.
douardda added a commit: rDPROV4ed652e03d12: Move all non pytest-related functions from conftest to utils.py.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
provenance/
tests/
97 lines100%
Loading...
data/
2 lines29%
Loading...
3 lines63%
Loading...
4 lines100%
Loading...
3 lines100%
Loading...
3 lines100%
Loading...
3 lines100%
Loading...
3 lines100%
Loading...
3 lines100%
Loading...
8 lines98%
Loading...
3 lines100%
Loading...
3 lines100%
Loading...
3 lines100%
Loading...
3 lines97%
Loading...
2 lines100%
Loading...
8 lines100%
Loading...
3 lines100%
Loading...
--
utils.py
conftest.py
99 lines80%
Loading...

Diff 31402

View Options

swh/provenance/tests/conftest.py

Loading...
View Options

swh/provenance/tests/data/generate_graph_dataset.py

Loading...
View Options

swh/provenance/tests/test_archive_interface.py

Loading...
View Options

swh/provenance/tests/test_cli.py

Loading...
View Options

swh/provenance/tests/test_conftest.py

Loading...
View Options

swh/provenance/tests/test_consistency.py

Loading...
View Options

swh/provenance/tests/test_directory_flatten.py

Loading...
View Options

swh/provenance/tests/test_directory_iterator.py

Loading...
View Options

swh/provenance/tests/test_history_graph.py

Loading...
View Options

swh/provenance/tests/test_isochrone_graph.py

Loading...
View Options

swh/provenance/tests/test_journal_client.py

Loading...
View Options

swh/provenance/tests/test_origin_iterator.py

Loading...
View Options

swh/provenance/tests/test_origin_revision_layer.py

Loading...
View Options

swh/provenance/tests/test_provenance_storage.py

Loading...
View Options

swh/provenance/tests/test_replay.py

Loading...
View Options

swh/provenance/tests/test_revision_content_layer.py

Loading...
View Options

swh/provenance/tests/test_revision_iterator.py

Loading...
View Options

swh/provenance/tests/test_utils.py

Loading...
View Options

swh/provenance/tests/utils.py

Loading...
About · Developer information · Legal