Improve directory entry name filtering uisng casefolded strings
ClosedPublic
Actions

Authored by jayeshv on Oct 18 2022, 9:12 AM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDGQLc6d410118d07: Improve directory entry name filtering uisng casefolded strings

Diff Detail

Repository

rDGQL GraphQL API

Branch

casrfold

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 32348
Build 50664: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 50663: arc lint + arc unit

Event Timeline

jayeshv created this revision.Oct 18 2022, 9:12 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 18 2022, 9:12 AM

Build is green

Patch application report for D8694 (id=31400)

Rebasing onto bc6f6a7269...

Current branch diff-target is up to date.

Changes applied before test

commit 2053e5de27bd1c7da3ae340206d8f5e5d6c4dc58
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Oct 18 08:53:20 2022 +0200

    Improve directory entry name filtering uisng casefolded strings

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/216/ for more details.

Harbormaster completed remote builds in B32348: Diff 31400.Oct 18 2022, 9:15 AM

jayeshv requested review of this revision.Oct 18 2022, 9:15 AM

anlambert requested changes to this revision.Oct 18 2022, 11:49 AM

anlambert added a subscriber: anlambert.

anlambert added inline comments.

swh/graphql/tests/data.py
130	s/speical/special/
135	Could you use a more meaningful example as UTF-8 string and add a dedidcated test ? For instance casefold will turn german letter ß into ss.

This revision now requires changes to proceed.Oct 18 2022, 11:49 AM

jayeshv added inline comments.Oct 18 2022, 11:58 AM

swh/graphql/tests/data.py
135	b"\xc3\x9f\xc3\x9f\xc3\xa9tE\xc3\x89t".decode() == "ßßétEÉt" The tests are using "ßßétEÉ" to search. (It is generic with pytest. parametrize where name include is always entry_name[:-1]) I too would like to make this explicit, maybe I will add a new test for this.

anlambert added inline comments.Oct 18 2022, 12:01 PM

swh/graphql/tests/data.py
135	Use `"ßßétEÉt".encode()` then and add a test searching for `"ss"` in directory entry.

address review commnets

jayeshv marked 3 inline comments as done.Oct 18 2022, 12:14 PM

Build is green

Patch application report for D8694 (id=31408)

Rebasing onto bc6f6a7269...

Current branch diff-target is up to date.

Changes applied before test

commit c6d410118d075640f66c70a89f2003abcca8a8bd
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Oct 18 08:53:20 2022 +0200

    Improve directory entry name filtering uisng casefolded strings

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/217/ for more details.

Harbormaster completed remote builds in B32353: Diff 31408.Oct 18 2022, 12:16 PM

Looks good to me.

This revision is now accepted and ready to land.Oct 18 2022, 12:17 PM

Closed by commit rDGQLc6d410118d07: Improve directory entry name filtering uisng casefolded strings (authored by jayeshv). · Explain WhyOct 18 2022, 12:22 PM

This revision was automatically updated to reflect the committed changes.

jayeshv added a commit: rDGQLc6d410118d07: Improve directory entry name filtering uisng casefolded strings.