Page MenuHomeSoftware Heritage

Rename GitLabListerTask in _GitLabListerTaskBase
AbandonedPublic

Authored by douardda on Thu, Dec 20, 4:20 PM.

Details

Reviewers
vlorentz
ardumont
Group Reviewers
Reviewers
Summary

since

1/ it's a 'private' class (no reason to use it from any other place
than this module), and

2/ it's an 'abstract' base class

This is needed (at least one of the 2 parts of the rename, but both make
sense semantically for the reasons listed above) to make it compatible
with the new auto register mechanism introduced in swh-scheduler 0.0.38;
note however that this requires D868 to behave properly.

Diff Detail

Repository
rDLS Listers
Branch
fix-gitlab
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3221
Build 4130: tox-on-jenkinsJenkins
Build 4129: arc lint + arc unit

Event Timeline

douardda created this revision.Thu, Dec 20, 4:20 PM
vlorentz accepted this revision.Thu, Dec 20, 4:21 PM
This revision is now accepted and ready to land.Thu, Dec 20, 4:21 PM
ardumont accepted this revision.Thu, Dec 20, 4:23 PM
douardda abandoned this revision.Tue, Jan 8, 11:30 AM

Not needed any more after D889