journal.publisher: Fix multiple issues and add logging
ClosedPublic
Actions

Authored by ardumont on Dec 20 2018, 2:21 PM.

Details

Reviewers

Group Reviewers

Commits

rDJNL11fb891781df: publisher: Be compliant with other endpoints
rDJNL9c90d92a15ea: publisher: Add logging
rDJNL1e4106b1800e: journal.publisher: Filter on existing revisions
rDJNL66dbf6549a82: journal.publisher: Allow to run in debug mode

Summary

Revealed by actually running kafka with docker.

Test Plan

tox

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 20 2018, 2:21 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 20 2018, 2:21 PM

ardumont added a child revision: D860: docker-compose: Add journal stack.Dec 20 2018, 2:22 PM

Harbormaster completed remote builds in B3197: Diff 2753.Dec 20 2018, 2:23 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/19/ for more details.

vlorentz accepted this revision.Dec 20 2018, 2:30 PM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/journal/publisher.py
56–57	why `######`?
172	same question here and below

This revision is now accepted and ready to land.Dec 20 2018, 2:30 PM

ardumont marked an inline comment as done.Dec 20 2018, 2:34 PM

ardumont added inline comments.

swh/journal/publisher.py
56–57	arf to see them, i forgot to remove those.

Remove wrong log formats

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/24/ for more details.

Harbormaster completed remote builds in B3200: Diff 2758.Dec 20 2018, 2:37 PM

Closed by commit rDJNL66dbf6549a82: journal.publisher: Allow to run in debug mode (authored by ardumont). · Explain WhyDec 20 2018, 2:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

journal/

publisher.py

27 lines

Diff 2759

View Options

journal.publisher: Fix multiple issues and add loggingClosedPublicActions