Differential D8638

npm: Fix crash on invalid URLs in 'bugs' field.
ClosedPublic
Actions

Authored by vlorentz on Oct 7 2022, 11:35 AM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

Restricted Maniphest Task

Commits

rDCIDX43125ac8dad6: npm: Fix crash on invalid URLs in 'bugs' field.

Summary

Resolves T4611.

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 32155
Build 50352: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 50351: arc lint + arc unit

Event Timeline

vlorentz created this revision.Oct 7 2022, 11:35 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 7 2022, 11:35 AM

Build is green

Patch application report for D8638 (id=31200)

Rebasing onto 74867bf361...

Current branch diff-target is up to date.

Changes applied before test

commit 43125ac8dad61f76967158f68db98422f1e3a383
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Oct 7 11:34:41 2022 +0200

    npm: Fix crash on invalid URLs in 'bugs' field.

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/513/ for more details.

Harbormaster completed remote builds in B32155: Diff 31200.Oct 7 2022, 11:43 AM

vlorentz requested review of this revision.Oct 7 2022, 11:43 AM

anlambert accepted this revision.Oct 7 2022, 12:00 PM

This revision is now accepted and ready to land.Oct 7 2022, 12:00 PM

Closed by commit rDCIDX43125ac8dad6: npm: Fix crash on invalid URLs in 'bugs' field. (authored by vlorentz). · Explain WhyOct 7 2022, 12:01 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCIDX43125ac8dad6: npm: Fix crash on invalid URLs in 'bugs' field..

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

indexer/

metadata_dictionary/

npm.py

10 lines

94%

tests/

metadata_dictionary/

test_npm.py

6 lines

100%

Diff 31200

View Options

swh/indexer/metadata_dictionary/npm.py