Page MenuHomeSoftware Heritage

nixguix: Exclude faulty "recursive" file origins from listing
ClosedPublic

Authored by ardumont on Oct 6 2022, 4:02 PM.

Details

Summary

For now, those can be faulty as the manifest is missing 'critical' information about how
to recompute the hash (e.g. fs layout, executable bit, ...).

The problem has been reported upstream [1]. In the meantime, this looks like a good way
to avoid injecting noise within the archive.

[1] Related to T4608
Related to T3781

Diff Detail

Repository
rDLS Listers
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 32162
Build 50364: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 50363: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D8637 (id=31182)

Rebasing onto 5a53243bd3...

Current branch diff-target is up to date.
Changes applied before test
commit 84ca47e08a38cf823abd07e72d6fa1b50cbffdae
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 6 15:38:30 2022 +0200

    nixguix: Exclude faulty "recursive" file origins from listing
    
    For now, those can be faulty as the manifest is missing 'critical' information about how
    to recompute the hash (e.g. fs layout, executable bit, ...).
    
    Related to T4608
    Related to T3781

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/768/ for more details.

Explicit the skipping step

Build is green

Patch application report for D8637 (id=31184)

Rebasing onto 5a53243bd3...

Current branch diff-target is up to date.
Changes applied before test
commit 93bf0afc1288379e434197cfe9fa8ba941140d20
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 6 15:38:30 2022 +0200

    nixguix: Exclude faulty "recursive" file origins from listing
    
    For now, those can be faulty as the manifest is missing 'critical' information about how
    to recompute the hash (e.g. fs layout, executable bit, ...).
    
    Related to T4608
    Related to T3781

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/769/ for more details.

vlorentz requested changes to this revision.Oct 7 2022, 1:46 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/lister/nixguix/lister.py
436–440

"Not ready git" or "Not ready url" doesn't mean anything to potential readers.

This revision now requires changes to proceed.Oct 7 2022, 1:46 PM
swh/lister/nixguix/lister.py
436–440

i made an effort on the comment and not on that warning...

Build is green

Patch application report for D8637 (id=31207)

Rebasing onto 5a53243bd3...

Current branch diff-target is up to date.
Changes applied before test
commit c22f41a6d74c44ea967119c2e88dd2e07d072efe
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 6 15:38:30 2022 +0200

    nixguix: Exclude faulty "recursive" file origins from listing
    
    For now, those can be faulty as the manifest is missing 'critical' information about how
    to recompute the hash (e.g. fs layout, executable bit, ...).
    
    Related to T4608
    Related to T3781

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/772/ for more details.

This revision is now accepted and ready to land.Oct 7 2022, 2:45 PM