nixguix: Exclude faulty "recursive" file origins from listing
ClosedPublic
Actions

Authored by ardumont on Oct 6 2022, 4:02 PM.

Details

Reviewers

Group Reviewers

Maniphest Tasks

T3781: Replace the Nixguix loader with a lister
T4608: nixpkgs manifests list "recursive" file which are missing information to recompute their hashes

Commits

rDLSc22f41a6d74c: nixguix: Exclude faulty "recursive" file origins from listing

Summary

For now, those can be faulty as the manifest is missing 'critical' information about how
to recompute the hash (e.g. fs layout, executable bit, ...).

The problem has been reported upstream [1]. In the meantime, this looks like a good way
to avoid injecting noise within the archive.

[1] Related to T4608
Related to T3781

Diff Detail

Repository

rDLS Listers

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 32142
Build 50328: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 50327: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 6 2022, 4:02 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 6 2022, 4:02 PM

ardumont mentioned this in T4608: nixpkgs manifests list "recursive" file which are missing information to recompute their hashes.Oct 6 2022, 4:02 PM

Build is green

Patch application report for D8637 (id=31182)

Rebasing onto 5a53243bd3...

Current branch diff-target is up to date.

Changes applied before test

commit 84ca47e08a38cf823abd07e72d6fa1b50cbffdae
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 6 15:38:30 2022 +0200

    nixguix: Exclude faulty "recursive" file origins from listing
    
    For now, those can be faulty as the manifest is missing 'critical' information about how
    to recompute the hash (e.g. fs layout, executable bit, ...).
    
    Related to T4608
    Related to T3781

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/768/ for more details.

Harbormaster completed remote builds in B32140: Diff 31182.Oct 6 2022, 4:07 PM

ardumont requested review of this revision.Oct 6 2022, 4:07 PM

Explicit the skipping step

Build is green

Patch application report for D8637 (id=31184)

Rebasing onto 5a53243bd3...

Current branch diff-target is up to date.

Changes applied before test

commit 93bf0afc1288379e434197cfe9fa8ba941140d20
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 6 15:38:30 2022 +0200

    nixguix: Exclude faulty "recursive" file origins from listing
    
    For now, those can be faulty as the manifest is missing 'critical' information about how
    to recompute the hash (e.g. fs layout, executable bit, ...).
    
    Related to T4608
    Related to T3781

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/769/ for more details.

Harbormaster completed remote builds in B32142: Diff 31184.Oct 6 2022, 4:46 PM

ardumont edited the summary of this revision. (Show Details)Oct 6 2022, 6:05 PM

ardumont mentioned this in T3781: Replace the Nixguix loader with a lister.Oct 6 2022, 6:15 PM

vlorentz requested changes to this revision.Oct 7 2022, 1:46 PM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/lister/nixguix/lister.py
437–441	"Not ready git" or "Not ready url" doesn't mean anything to potential readers.

This revision now requires changes to proceed.Oct 7 2022, 1:46 PM

ardumont added inline comments.Oct 7 2022, 2:33 PM

swh/lister/nixguix/lister.py
437–441	i made an effort on the comment and not on that warning...

Amend warning message

ardumont marked an inline comment as done.Oct 7 2022, 2:34 PM

Build is green

Patch application report for D8637 (id=31207)

Rebasing onto 5a53243bd3...

Current branch diff-target is up to date.

Changes applied before test

commit c22f41a6d74c44ea967119c2e88dd2e07d072efe
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 6 15:38:30 2022 +0200

    nixguix: Exclude faulty "recursive" file origins from listing
    
    For now, those can be faulty as the manifest is missing 'critical' information about how
    to recompute the hash (e.g. fs layout, executable bit, ...).
    
    Related to T4608
    Related to T3781

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/772/ for more details.

Harbormaster completed remote builds in B32162: Diff 31207.Oct 7 2022, 2:39 PM

vlorentz accepted this revision.Oct 7 2022, 2:45 PM

This revision is now accepted and ready to land.Oct 7 2022, 2:45 PM

Closed by commit rDLSc22f41a6d74c: nixguix: Exclude faulty "recursive" file origins from listing (authored by ardumont). · Explain WhyOct 7 2022, 4:37 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLSc22f41a6d74c: nixguix: Exclude faulty "recursive" file origins from listing.